Task #55765

Remove duplicated code in fileList method of SelectImage class

Added by Tymoteusz Motylewski almost 6 years ago. Updated about 1 year ago.

Status:
Closed
Priority:
Should have
Category:
Code Cleanup
Target version:
-
Start date:
2014-02-07
Due date:
% Done:

100%

TYPO3 Version:
6.2
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

The fileList method of Rtehtmlarea\SelectImage is almost exact copy
of the parent implementation from ElementBrowser.

We should merge both methods, so it's easier to maintain.
The positive side effect of this change would be to have consistent look and behavior between RTE and normal element browser.


Related issues

Precedes TYPO3 Core - Bug #55939: Regression in ElementBrowser: only images are selectable Closed 2014-02-12

Associated revisions

Revision 162ead51 (diff)
Added by Tymoteusz Motylewski almost 6 years ago

[TASK] Remove duplicated method in Rtehtmlarea\SelectImage

fileList() of Rtehtmlarea\SelectImage is almost an exact copy
of the parent implementation from ElementBrowser.

The patch removes fileList() from SelectImage and merges changes
to ElementBrowser.

It also fixes some bugs in magic image selector from RTE:
  • Missing columns
  • Wrong links to info page
  • Fix "import selection" option

Resolves: #55765
Releases: 6.2
Change-Id: I78cb23de16b9516f953628aad10cf548f558bfd7
Reviewed-on: https://review.typo3.org/27414
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Marcin Sągol
Tested-by: Marcin Sągol
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

History

#1 Updated by Gerrit Code Review almost 6 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27414

#2 Updated by Gerrit Code Review almost 6 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27414

#3 Updated by Gerrit Code Review almost 6 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27414

#4 Updated by Tymoteusz Motylewski almost 6 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#5 Updated by Alexander Stehlik almost 6 years ago

Introduced regression: #55939

#6 Updated by Benni Mack about 1 year ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF