Project

General

Profile

Actions

Task #55765

closed

Remove duplicated code in fileList method of SelectImage class

Added by Tymoteusz Motylewski almost 11 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Should have
Category:
Code Cleanup
Target version:
-
Start date:
2014-02-07
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
6.2
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

The fileList method of Rtehtmlarea\SelectImage is almost exact copy
of the parent implementation from ElementBrowser.

We should merge both methods, so it's easier to maintain.
The positive side effect of this change would be to have consistent look and behavior between RTE and normal element browser.


Related issues 1 (0 open1 closed)

Precedes TYPO3 Core - Bug #55939: Regression in ElementBrowser: only images are selectableClosed2014-02-12

Actions
Actions #1

Updated by Gerrit Code Review almost 11 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27414

Actions #2

Updated by Gerrit Code Review almost 11 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27414

Actions #3

Updated by Gerrit Code Review almost 11 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27414

Actions #4

Updated by Tymoteusz Motylewski almost 11 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #5

Updated by Alexander Stehlik almost 11 years ago

Introduced regression: #55939

Actions #6

Updated by Benni Mack about 6 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF