Project

General

Profile

Actions

Bug #56019

closed

ResourceCompressor: concatenateCss with forceOnTop gives wrong order

Added by Stefan Neufeind about 10 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Frontend
Target version:
-
Start date:
2014-02-16
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
6.2
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

While testing #53116 (about concatenateJs and forceOnTop) I also checked if that part works fine for CSS. The forceOnTop works if you don't concatenate them:

page >

config.concatenateCss = 0
page = PAGE
page {
  includeCSS {
    b = fileadmin/b.css
    b {
      forceOnTop = 0
    }
    c = fileadmin/c.css
    c {
      forceOnTop = 1
    }
    a = fileadmin/a.css
    a {
      forceOnTop = 1
    }
  }
}

gives:
<link rel="stylesheet" type="text/css" href="fileadmin/a.css?1392566437" media="all">
<link rel="stylesheet" type="text/css" href="fileadmin/c.css?1392566430" media="all">

<link rel="stylesheet" type="text/css" href="typo3temp/stylesheet_993134cfc3.css?1385132976" media="all">
<link rel="stylesheet" type="text/css" href="fileadmin/b.css?1392566433" media="all">

(okay, we might look if we can get rid of that newline in the middle)

But with config.concatenateCss = 1 the order is then:
  • default CSS
  • b
  • c
  • a
Expected behaviour (as in non-concatenated example):
  • a
  • c
  • default CSS
  • b

Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Bug #53116: concatenateJs in conjunction with forceOnTopClosed2013-10-25

Actions
Actions #1

Updated by Markus Klein about 10 years ago

Hi! I checked that too, but forceOnTop for includeCSS is not documented to exist.

http://docs.typo3.org/typo3cms/TyposcriptReference/latest/Setup/Page/#includecss-array

Actions #2

Updated by Stefan Neufeind about 10 years ago

Oh my :-( But it works if you don't concatenate. Imho then we should:
  • fix it for the concatenate-case as a "TASK" (make the functionality complete)
  • document it
Actions #3

Updated by Gerrit Code Review about 10 years ago

  • Status changed from New to Under Review

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27640

Actions #4

Updated by Gerrit Code Review about 10 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27640

Actions #5

Updated by Gerrit Code Review about 10 years ago

Patch set 1 for branch TYPO3_6-1 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27672

Actions #6

Updated by Markus Klein about 10 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #7

Updated by Benni Mack over 5 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF