Task #56109

Epic #55070: Workpackages

Epic #55065: WP: Overall System Performance (Backend and Frontend)

Cleanup \TYPO3\CMS\Lang\LanguageService

Added by Michiel Roos over 5 years ago. Updated almost 2 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
Start date:
2014-02-19
Due date:
% Done:

100%

TYPO3 Version:
6.2
PHP Version:
5.3
Tags:
Complexity:
medium
Sprint Focus:

Description

The calls to sL() are reportedly not allways returned from \TYPO3\CMS\Lang\LanguageService::$LL_labels_cache
Amongst other things:
  • See if we can also cache the HSC values on sL() calls in the \TYPO3\CMS\Lang\LanguageService::$LL_labels_cache
  • loadSingleTableDescription calls methods inside nested foreach loops. Each of the methods test unchanging values for being an array etc. over and over.
  • Replace count() calls with !empty() if we are dealing with objects known to be an array

Associated revisions

Revision 16c5c810 (diff)
Added by Michiel Roos over 5 years ago

[TASK] Cleanup \TYPO3\CMS\Lang\LanguageService

  • Cache hsc values of calls to sL()
  • Code cleanup
  • Use !empty() instead of count() for objects known to be an array

Change-Id: Ie015f9755b98c41df185865325ea15ce42179e23
Resolves: #56109
Releases: 6.2
Reviewed-on: https://review.typo3.org/27745
Reviewed-by: Steffen Ritter
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Oliver Klee
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

History

#1 Updated by Ingo Schmitt over 5 years ago

  • Parent task set to #55065

#2 Updated by Gerrit Code Review over 5 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27745

#3 Updated by Gerrit Code Review over 5 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27745

#4 Updated by Gerrit Code Review over 5 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27745

#5 Updated by Michiel Roos over 5 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#6 Updated by Riccardo De Contardi almost 2 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF