Project

General

Profile

Actions
Copy link

Task #56110

closed

Epic #55070: Workpackages

Epic #55065: WP: Overall System Performance (Backend and Frontend)

IconUtility::getSpriteIcon() needs a cache

Added by Michiel Roos almost 11 years ago. Updated over 7 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
6.2.0
Start date:
2014-02-19
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
6.2
PHP Version:
5.3
Tags:
Complexity:
no-brainer
Sprint Focus:

Description

IconUtility::getSpriteIcon() is used heavily in many parts of the backend Treeview, page and list to name a few areas.

Most of the calls (279) use just the first parameter: $iconName

Many callers (135) use more parameters.

The calls with just the one parameter can be cached, preventing rendering the same code over and over again (in list mode and page tree for example).

Related issues 1 (0 open — 1 closed)

Related to TYPO3 Core - Bug #56725: Improve mocking in IconUtilityTestClosed2014-03-10

Actions
Actions
Copy link
 #2

Updated by Gerrit Code Review almost 11 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27713

Actions
Copy link
 #3

Updated by Ingo Schmitt almost 11 years ago

  • Parent task set to #55065
Actions
Copy link
 #4

Updated by Gerrit Code Review almost 11 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27713

Actions
Copy link
 #5

Updated by Gerrit Code Review almost 11 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27713

Actions
Copy link
 #6

Updated by Gerrit Code Review almost 11 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27713

Actions
Copy link
 #7

Updated by Gerrit Code Review almost 11 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27713

Actions
Copy link
 #8

Updated by Gerrit Code Review almost 11 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27713

Actions
Copy link
 #9

Updated by Gerrit Code Review almost 11 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27713

Actions
Copy link
 #10

Updated by Michiel Roos almost 11 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions
Copy link
 #11

Updated by Riccardo De Contardi over 7 years ago

  • Status changed from Resolved to Closed
Actions
Copy link

Also available in: Atom PDF