Project

General

Profile

Actions

Bug #56233

closed

Epic #55575: Streamline JavaScript Code in the TYPO3 Backend

Load order of js files differs

Added by Daniel Siepmann about 10 years ago. Updated about 9 years ago.

Status:
Closed
Priority:
Should have
Category:
Frontend
Target version:
-
Start date:
2014-02-24
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
4.7
PHP Version:
5.3
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

There is a difference of ordering for js files, in case they are compressed / concatenated or not.
Looks like pagerenderer inverses the "forceOnTop files" while the ResourceCompressor doesn't.


if ($properties['forceOnTop']) {
    if ($properties['section'] === self::PART_HEADER) {
        $jsFiles = $tag . LF . $jsFiles;
    } else {
        $jsFooterFiles = $tag . LF . $jsFooterFiles;
    }
} else {
    if ($properties['section'] === self::PART_HEADER) {
        $jsFiles .= LF . $tag;
    } else {
        $jsFooterFiles .= LF . $tag;
    }
}

Instead of prepanding the file we should use the same logic as in ResourceCompressor. We should build arrays for each kind of section and merge them at the end.

The change of order should be communicated on launch. That's a breaking change for JS developers. They have to check the order of there JS files.


Related issues 1 (0 open1 closed)

Is duplicate of TYPO3 Core - Bug #53116: concatenateJs in conjunction with forceOnTopClosed2013-10-25

Actions
Actions #1

Updated by Daniel Siepmann about 10 years ago

Getting deeper, it looks like pagerenderer is right and Compressor should take care of forceOnTop. Currently this setting is just ignored.

Actions #2

Updated by Markus Klein about 10 years ago

Wait a bit, there's already a patch of mine pending I guess.

Actions #3

Updated by Markus Klein about 10 years ago

  • Target version deleted (6.2.0)

Duplicate of #53116.

Merged in 6.1 and 6.2.

We've to ask the release managers whether backports to < 6.1 are allowed.

But wait a bit, if you intend to use this on any other version, as a patch for #56242 is pending.

Actions #4

Updated by Daniel Siepmann about 10 years ago

  • Parent task set to #55575
Actions #5

Updated by Benni Mack about 9 years ago

  • Status changed from New to Closed
Actions

Also available in: Atom PDF