Bug #56569
closedSystemEnvironment check shouldn't give error on fileUpload values in CLI context
100%
Description
When the SystemEnvironment check is run over CLI (for instance when called by reports scheduler task) it shouldn't give a warning
for the fileUpload tests as the php.ini can be different for cli mode.
- checkFileUploadEnabled()
- checkMaximumFileUploadSize()
- checkPostUploadSizeIsHigherOrEqualMaximumFileUploadSize()
Updated by Gerrit Code Review about 10 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/29261
Updated by Gerrit Code Review about 10 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/29261
Updated by Frans Saris almost 10 years ago
Until we find a generic way to disable the failing reports in CLI mode I added this to my ext_tables.php.
// Disable "EnvironmentStatusReport" when run in cli mode if (defined('TYPO3_cliMode') && TYPO3_cliMode) { if (($reportKey = array_search('TYPO3\\CMS\\Install\\Report\\EnvironmentStatusReport', $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['reports']['tx_reports']['status']['providers']['system'])) !== FALSE) { unset($GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['reports']['tx_reports']['status']['providers']['system'][$reportKey]); } }
This makes sure that the Environment Status Report is not added when called in cli mode
Updated by Gerrit Code Review over 9 years ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/29261
Updated by Christian Kuhn over 9 years ago
- Status changed from Under Review to New
The first patch was abandoned now in gerrit.
Just disabling the whole CheckEnvironment reports thingie if in cli mode seems to be a much better solution at first glance already. Feel free to push that, Frans. At least the system environment check already encapsulates many of the php cli / other sapi relatated checks, which is good.
Updated by Gerrit Code Review over 9 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35954
Updated by Frederic Gaus over 9 years ago
Disabling the whole thing would be possible. But I would like a solution like Markus recommended best:
Quick concept: * public php script that returns the status as JSON * IP based protection for accessing this script * strong default that only allows ::1 and 127.0.0.1
Updated by Frans Saris over 9 years ago
Does this work on shared hosting? How to determine the correct host name?
Updated by Gerrit Code Review over 9 years ago
Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/36104
Updated by Gerrit Code Review over 9 years ago
Patch set 2 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/36104
Updated by Frans Saris over 9 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 3099f0bd1052c7aa22dfe88f460152b581238099.