Project

General

Profile

Actions

Bug #56569

closed

SystemEnvironment check shouldn't give error on fileUpload values in CLI context

Added by Frans Saris about 10 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Install Tool
Target version:
-
Start date:
2014-03-05
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
6.2
PHP Version:
Tags:
Complexity:
easy
Is Regression:
No
Sprint Focus:

Description

When the SystemEnvironment check is run over CLI (for instance when called by reports scheduler task) it shouldn't give a warning
for the fileUpload tests as the php.ini can be different for cli mode.

  • checkFileUploadEnabled()
  • checkMaximumFileUploadSize()
  • checkPostUploadSizeIsHigherOrEqualMaximumFileUploadSize()

Related issues 7 (0 open7 closed)

Related to TYPO3 Core - Task #33203: System Status Update (reports) - different readings on PHP Memory Limit etc. Closed2012-01-15

Actions
Related to TYPO3 Core - Feature #25691: Test-Task should check for PHP CLI Memory-LimitClosed2011-02-21

Actions
Related to TYPO3 Core - Feature #52283: Mark some env-tests as skipped when running on cliClosed2013-09-26

Actions
Related to TYPO3 Core - Feature #62101: System Status Update tests should test frontend environment not cli environmentClosed2014-10-08

Actions
Related to TYPO3 Core - Bug #24793: Different environment variables in CLI - add hint to mailClosed2011-01-25

Actions
Related to TYPO3 Core - Feature #24572: Notification Emails for system status updatesClosedIngo Renner2011-01-14

Actions
Related to TYPO3 Core - Task #64876: Remove unused cli check in SystemEnvironment CheckClosed2015-02-05

Actions
Actions #1

Updated by Gerrit Code Review about 10 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/29261

Actions #2

Updated by Gerrit Code Review about 10 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/29261

Actions #3

Updated by Frans Saris almost 10 years ago

Until we find a generic way to disable the failing reports in CLI mode I added this to my ext_tables.php.

// Disable "EnvironmentStatusReport" when run in cli mode
if (defined('TYPO3_cliMode') && TYPO3_cliMode) {
    if (($reportKey = array_search('TYPO3\\CMS\\Install\\Report\\EnvironmentStatusReport', $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['reports']['tx_reports']['status']['providers']['system'])) !== FALSE) {
        unset($GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['reports']['tx_reports']['status']['providers']['system'][$reportKey]);
    }
}

This makes sure that the Environment Status Report is not added when called in cli mode

Actions #4

Updated by Gerrit Code Review over 9 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/29261

Actions #5

Updated by Christian Kuhn over 9 years ago

  • Status changed from Under Review to New

The first patch was abandoned now in gerrit.

Just disabling the whole CheckEnvironment reports thingie if in cli mode seems to be a much better solution at first glance already. Feel free to push that, Frans. At least the system environment check already encapsulates many of the php cli / other sapi relatated checks, which is good.

Actions #6

Updated by Gerrit Code Review over 9 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35954

Actions #7

Updated by Frederic Gaus over 9 years ago

Disabling the whole thing would be possible. But I would like a solution like Markus recommended best:
Quick concept: * public php script that returns the status as JSON * IP based protection for accessing this script * strong default that only allows ::1 and 127.0.0.1

Actions #8

Updated by Frans Saris over 9 years ago

Does this work on shared hosting? How to determine the correct host name?

Actions #9

Updated by Gerrit Code Review over 9 years ago

Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/36104

Actions #10

Updated by Gerrit Code Review over 9 years ago

Patch set 2 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/36104

Actions #11

Updated by Frans Saris over 9 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #12

Updated by Benni Mack over 5 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF