Bug #57053

Regression: Extbase query builder uses invalid parameter in parseComparison()

Added by Alexander Stehlik over 5 years ago. Updated about 2 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Extbase
Target version:
Start date:
2014-03-18
Due date:
% Done:

100%

TYPO3 Version:
6.2
PHP Version:
5.4
Tags:
Complexity:
Is Regression:
Yes
Sprint Focus:

Description

The parseComparison() method of the query builder uses unnamed parameters (?) for building comparisons with records from foreign / mm tables.

The name query parameter should be used there.


Related issues

Related to TYPO3 Core - Task #55167: Extbase: avoid parseQuery() / buildQuery() to be called multiple times Closed 2014-03-20 2014-03-20

Associated revisions

Revision b8edbf13 (diff)
Added by Alexander Stehlik over 5 years ago

[BUGFIX] Named parameters in Extbase comparison queries

Instead of using unnamend parameters (?) in parseComparison() in the
Extbase Typo3DbQueryParser the matching parameter identifier will be
used for building the comparison SQL.

Additionally the non existing "$parameters" method parameter is removed
from a lot of method calls.

Resolves: #57053
Related: #55167
Releases: 6.2
Change-Id: I1123275af57e8803ecd792d65f91627cef54f501
Reviewed-on: https://review.typo3.org/28511
Reviewed-by: Felix Oertel
Tested-by: Felix Oertel
Reviewed-by: Wouter Wolters
Reviewed-by: Markus Klein
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers

History

#1 Updated by Gerrit Code Review over 5 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/28511

#2 Updated by Gerrit Code Review over 5 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/28511

#3 Updated by Ernesto Baschny over 5 years ago

  • Target version set to 6.2.0

#4 Updated by Gerrit Code Review over 5 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/28511

#5 Updated by Gerrit Code Review over 5 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/28511

#6 Updated by Gerrit Code Review over 5 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/28511

#7 Updated by Alexander Stehlik over 5 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#8 Updated by Riccardo De Contardi about 2 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF