Project

General

Profile

Actions
Copy link

Bug #57100

closed

Sys_log gets spammed with

Added by Kay Strobach over 10 years ago. Updated over 9 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2014-03-20
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
6.1
PHP Version:
5.3
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

Core: Error handler (FE): PHP Warning: implode() [<a href='function.implode'>function.implode</a>]: Invalid arguments passed in /typo3_src-6.1.7/typo3/sysext/core/Classes/Utility/RootlineUtility.php line 276

PHP: 5.3.19
TYPO3 6.1.7

    line causing trouble
    $pageRecord[$column] = implode(',', $relatedUids);

solution wrap in is_array and return sth. else if $relatedUids is not an array ...

Regards
Kay

Actions
Copy link
 #1

Updated by Markus Klein over 10 years ago

  • Status changed from New to Needs Feedback

Seems you run through the if branch with this code:

if ($configuration['MM']) {
    /** @var $loadDBGroup \TYPO3\CMS\Core\Database\RelationHandler */
    $loadDBGroup = \TYPO3\CMS\Core\Utility\GeneralUtility::makeInstance('TYPO3\\CMS\\Core\\Database\\RelationHandler');
    $loadDBGroup->start($pageRecord[$column], $configuration['foreign_table'], $configuration['MM'], $uid, 'pages', $configuration);
    $relatedUids = $loadDBGroup->tableArray[$configuration['foreign_table']];

So $loadDBGroup->tableArray[$configuration['foreign_table']] does not return array, which looks more like a configuration error.

Actions
Copy link
 #2

Updated by Kay Strobach over 10 years ago

anyway there should be a clear error message (e.g in sys_log) instead of php warnings ... - right?
Do you think this is worth a patch?

I have not installed the installation where this happens :(

Actions
Copy link
 #3

Updated by Gerrit Code Review over 10 years ago

  • Status changed from Needs Feedback to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/28561

Actions
Copy link
 #4

Updated by Gerrit Code Review over 10 years ago

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/28562

Actions
Copy link
 #5

Updated by Kay Strobach over 10 years ago

so we have 2 different patches for the same problem ...

Actions
Copy link
 #6

Updated by Gerrit Code Review over 10 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/28561

Actions
Copy link
 #7

Updated by Gerrit Code Review over 10 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/28561

Actions
Copy link
 #8

Updated by Markus Klein over 10 years ago

  • Status changed from Under Review to Accepted

Comment of Olly Hader:

... "group/db" tables ("allowed" in TCA configuration) was not considered before - thus, the RootlineUtility handling in this regard is broken... This patch would just log away the Core bug... A good inspiration on how to use the RelationHandler is DataHandler, there e.g. look at method "remapListedDBRecords_procDBRefs()"

Actions
Copy link
 #9

Updated by Markus Klein over 9 years ago

  • Status changed from Accepted to Closed

No progress for a year. Closing this.

Actions
Copy link

Also available in: Atom PDF