Bug #57183

Class loader should exit early for invalid class names

Added by Helmut Hummel about 7 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
Start date:
2014-03-22
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
6.2
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

Why jumping through hoops, checking if we can find a class file (buildClassLoadingInformation) if we could know beforehand, that the class name is invalid and exit early? We could get rid of all try/catch and clearly behave like the PHP class loader do nothing at all and return early.
In fact PHP should not call an autoloader for invalid class names as the language should know about that, but as of now, we have to deal with it.
I mean several people proved, that this change has virtually no impact on performance and we still prefer a complicated solution (several try catch, trying to resolve class paths for classes that cannot exist) over a simple one (exit early)?

#1

Updated by Gerrit Code Review about 7 years ago

  • Status changed from New to Under Review

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/28553

#2

Updated by Gerrit Code Review about 7 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/28553

#3

Updated by Helmut Hummel about 7 years ago

  • Target version set to 6.2.0
#4

Updated by Gerrit Code Review about 7 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/28553

#5

Updated by Helmut Hummel about 7 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#6

Updated by Riccardo De Contardi over 3 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF