Bug #57183
closedClass loader should exit early for invalid class names
100%
Description
Why jumping through hoops, checking if we can find a class file (buildClassLoadingInformation) if we could know beforehand, that the class name is invalid and exit early? We could get rid of all try/catch and clearly behave like the PHP class loader do nothing at all and return early.
In fact PHP should not call an autoloader for invalid class names as the language should know about that, but as of now, we have to deal with it.
I mean several people proved, that this change has virtually no impact on performance and we still prefer a complicated solution (several try catch, trying to resolve class paths for classes that cannot exist) over a simple one (exit early)?
Updated by Gerrit Code Review over 10 years ago
- Status changed from New to Under Review
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/28553
Updated by Gerrit Code Review over 10 years ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/28553
Updated by Gerrit Code Review over 10 years ago
Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/28553
Updated by Helmut Hummel over 10 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 0e20f584f547b3b71595f871f7ecd52659c3c106.
Updated by Riccardo De Contardi about 7 years ago
- Status changed from Resolved to Closed