Bug #57367
closedPageLayoutViewDrawItemHookInterface has bad function definition
0%
Description
PageLayoutViewDrawItemHookInterface.php defines the preProcess function to have the first object parameter passed by reference.
This does not work out, as this reference is a) not required for functionality and b) called with $this, which can't be modified.
Updated by Gerrit Code Review over 10 years ago
- Status changed from Accepted to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/28901
Updated by Gerrit Code Review over 10 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/28901
Updated by Gerrit Code Review over 10 years ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/28901
Updated by Gerrit Code Review over 10 years ago
Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/28901
Updated by Markus Klein over 10 years ago
- Status changed from Under Review to Accepted
- Assignee deleted (
Markus Klein) - Priority changed from Must have to Should have
- Target version deleted (
next-patchlevel)
Will cause a change in the interface, which is a breaking change.
Postponed until... forever
Updated by Mathias Schreiber about 9 years ago
- Status changed from Accepted to Closed
we can re-open the issue when "forever" is over ;-)