Bug #57453
closed
TYPO3\CMS\Extbase\Validation\Validator\NumberValidator
100%
Description
The function-description shows that there SHOULD be a boolean return value but the Validator only adds an Error, no return value is given.
Updated by Nadine Schwingler about 10 years ago
I was talking about the isValid-Funtion inside the validator
Updated by Gerrit Code Review about 9 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/36143
Updated by Gerrit Code Review about 9 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/36143
Updated by Patrick Schriner about 9 years ago
Just out of curiosity, wouldn't it make more sense to add return FALSE / TRUE were missing instead of adapting the PHPDoc? I'd pretty much expect isValid to return a boolean.
Ok I just saw this has changed somewhere between 4.5 and 6.2
It was defined as returning a Boolean in the Interface in 4.5, but is not anymore.
Updated by Frederic Gaus about 9 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset af3809c2cf44707cebbf7ad7dfc22bbd0b8c3b9c.
Updated by Gerrit Code Review about 9 years ago
- Status changed from Resolved to Under Review
Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/36189
Updated by Frederic Gaus about 9 years ago
- Status changed from Under Review to Resolved
Applied in changeset 9dc5c4edfac6c8c7274bc922b40b269fce86e74d.
Updated by