Bug #57785

Wrong SCRIPT_NAME with hhvm / fastcgi

Added by Kevin Häfeli over 8 years ago. Updated almost 4 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
Start date:
2014-04-09
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
6.2
PHP Version:
5.5
Tags:
Complexity:
easy
Is Regression:
No
Sprint Focus:

Description

In the following core files there is a check for PHP_SAPI

./typo3/sysext/core/Classes/Utility/GeneralUtility.php
./typo3/sysext/core/Classes/Core/SystemEnvironmentBuilder.php
./typo3/sysext/install/Classes/Controller/Action/Tool/ImportantActions.php

if ($cgiPath && (PHP_SAPI === 'fpm-fcgi' || PHP_SAPI === 'cgi' || PHP_SAPI === 'isapi' || PHP_SAPI === 'cgi-fcgi')) {

this check sets the path / SCRIPT_NAME correct if your hoster is using mod_fastcgi /fcgid. Otherwise the install tool or backend login redirects you to:

www.domain.com/path/to/your/webroot/typo3/backend.php instead of:
www.domain.com/typo3/backend.php

some days ago facebook introduced HHVM with fastcgi support and it's amazing fast.
so, TYPO3 should support it :-)

one step is to extend the PHP_SAPI check with "srv" (hiphop vm's php-sapi name):

if ($cgiPath && (PHP_SAPI === 'fpm-fcgi' || PHP_SAPI === 'cgi' || PHP_SAPI === 'isapi' || PHP_SAPI === 'cgi-fcgi' || PHP_SAPI === 'srv')) {

#1

Updated by Markus Klein over 8 years ago

Hi khaefeli!

Thanks for posting this here?
Can you push a patch to our review system?

#2

Updated by Gerrit Code Review over 8 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/29335

#3

Updated by Gerrit Code Review over 8 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/29335

#4

Updated by Gerrit Code Review over 8 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/29335

#5

Updated by Gerrit Code Review over 8 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/29335

#6

Updated by Gerrit Code Review over 8 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/29335

#7

Updated by Gerrit Code Review over 8 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/29335

#8

Updated by Kevin Häfeli over 8 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#9

Updated by Benni Mack almost 4 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF