Bug #57914
closed
INCLUDE_TYPOSCRIPT should skip hidden/temporary files
0%
Description
INCLUDE_TYPOSCRIPT is processed in typo3/sysext/core/Classes/TypoScript/Parser/TypoScriptParser.php
When including a whole DIR it can occur that also files like ".myfile.ts.swp" are included. Those file are for example there while a file is open in vim. In BE the object-browser then complains about unexpected characters etc.
a) We should skip those hidden/temporary files. (Afaik there is a pattern for temporary files that we can use for the exclude.)
b) Why does it include a file ending with .swp? That file-extension should usually not be allowed to include.
Updated by Markus Klein over 10 years ago
Did you specify the extension parameter with the include?
Updated by Stefan Neufeind over 10 years ago
no I didn't. Just a plain include for a DIR with everything that it contains.
Updated by Stefan Neufeind over 10 years ago
Well, but we have a whitelist of allowed extensions. For example the editor does not allow you to save typoscript-files which end with .php. So we could use that whitelist as a default for the extension-parameter you mentioned.
Updated by Stefan Neufeind over 10 years ago
- Status changed from New to Under Review
Updated by Gerrit Code Review over 10 years ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/31694
Updated by Gerrit Code Review over 10 years ago
Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/31694
Updated by zimmer7 GmbH over 10 years ago
So, no progress here? What about patchset 4?
Updated by Gerrit Code Review almost 10 years ago
Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/31694
Updated by Gerrit Code Review over 9 years ago
Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/31694
Updated by Christian Kuhn over 8 years ago
- Status changed from Under Review to Rejected
patch wasn't finished for a long time.