Bug #58187

Bug #51768: IRRE - drag and drop sorting of items not possible in Internet Explorer

New prototype version produces stack overflow error in IE8

Added by Jigal van Hemert almost 6 years ago. Updated over 1 year ago.

Status:
Closed
Priority:
Must have
Category:
Backend User Interface
Target version:
-
Start date:
2014-04-25
Due date:
% Done:

100%

TYPO3 Version:
6.2
PHP Version:
Tags:
Complexity:
easy
Is Regression:
Yes
Sprint Focus:

Description

In IE8 the BE login screen produces the error message "Stack overflow at line 7".

See: https://gitorious.org/testlink-ga/testlink-code/commit/5a10db041cd08168847fee13228caed87a69ad20

The solution in this report works to solve the problem.

Associated revisions

Revision 7e65dc21 (diff)
Added by Jigal van Hemert almost 6 years ago

[BUGFIX] Solve stackoverflow in prototype in IE8

The reason for this behaviour is the combination of prototype.js
and ExtJS. The ExtJS defer() method takes precedence. Calling the
defer() method without any arguments would have resulted in using
a default value of "0.01" seconds in standalone prototype.js, but
results in directly calling the submitted function.

The stack overflow is caused by not delaying the function call
and thus ending in a recursive endless loop.

Resolves: #58187
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Change-Id: I6db191ff67a3e869072877936d949fc733cda74f
Reviewed-on: https://review.typo3.org/29655
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader

Revision fb8370d0 (diff)
Added by Jigal van Hemert almost 6 years ago

[BUGFIX] Solve stackoverflow in prototype in IE8

The reason for this behaviour is the combination of prototype.js
and ExtJS. The ExtJS defer() method takes precedence. Calling the
defer() method without any arguments would have resulted in using
a default value of "0.01" seconds in standalone prototype.js, but
results in directly calling the submitted function.

The stack overflow is caused by not delaying the function call
and thus ending in a recursive endless loop.

Resolves: #58187
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Change-Id: I6db191ff67a3e869072877936d949fc733cda74f
Reviewed-on: https://review.typo3.org/29907
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader

Revision 6ffdceeb (diff)
Added by Jigal van Hemert almost 6 years ago

[BUGFIX] Solve stackoverflow in prototype in IE8

The reason for this behaviour is the combination of prototype.js
and ExtJS. The ExtJS defer() method takes precedence. Calling the
defer() method without any arguments would have resulted in using
a default value of "0.01" seconds in standalone prototype.js, but
results in directly calling the submitted function.

The stack overflow is caused by not delaying the function call
and thus ending in a recursive endless loop.

Resolves: #58187
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Change-Id: I6db191ff67a3e869072877936d949fc733cda74f
Reviewed-on: https://review.typo3.org/29908
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader

History

#1 Updated by Gerrit Code Review almost 6 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/29655

#2 Updated by Gerrit Code Review almost 6 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/29655

#3 Updated by Oliver Hader almost 6 years ago

The reason for this behaviour is the combination of prototype.js and ExtJS.
The ExtJS defer() method takes precedence over Prototype's - later one uses a default value of "0.01" seconds - the value is passed to the native function setTimeout() in the delay() method of prototype.js.
The ExtJS variant directly uses the millisecond value - if "0" is given, the submitted function will be called directly.

The stack overflow is caused by not delaying the function call (delay value is "0") and thus ending in a recursive endless loop.

#4 Updated by Gerrit Code Review almost 6 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/29655

#5 Updated by Gerrit Code Review almost 6 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/29655

#6 Updated by Jigal van Hemert almost 6 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#7 Updated by Gerrit Code Review almost 6 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_6-1 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/29907

#8 Updated by Gerrit Code Review almost 6 years ago

Patch set 1 for branch TYPO3_4-5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/29908

#9 Updated by Jigal van Hemert almost 6 years ago

  • Status changed from Under Review to Resolved

#10 Updated by Benni Mack over 1 year ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF