Bug #58466
closed
Image Processing preset not properly detected
100%
Description
In case of active open_basedir restriction the detection of available Image Manipulation libraries might fail.
My setup tells the open_basedir allows /usr/bin/gm, but not /usr/bin. Therefor the condition is_dir(/usr/bin/) && @is_file(/usr/bin/gm) returns TRUE, where is_dir is FALSE and is_file is TRUE. surpresses the PHP Warning anyway.
The is_dir($path) is superflous, because @is_file does the same and the
Conclusion: it does not hurt to remove the @is_dir condition alltogether and for such restricted the environments as mine detect the library properly.
Updated by Gerrit Code Review almost 10 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/29822
Updated by Gerrit Code Review almost 10 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/29822
Updated by Gerrit Code Review almost 10 years ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/29822
Updated by Gerrit Code Review almost 10 years ago
Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/29822
Updated by Anja Leichsenring almost 10 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 71b9400b17af20a7ceaa3a9d1560910773c77f08.
Updated by