Task #58995

Code Cleanups in FormEngine

Added by Sebastian Michaelsen over 5 years ago. Updated about 1 year ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Code Cleanup
Target version:
-
Start date:
2014-05-21
Due date:
% Done:

100%

TYPO3 Version:
6.2
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

\TYPO3\CMS\Backend\Form\FormEngine could use a few cleanups:

  • Import some classes to avoid unnecessary fully qualified class names
  • Fix some PHPDoc issues
  • Slightly adjust some method signatures (when 0, 1, or '' were used for boolean information)
  • Remove some unused local variables

Related issues

Related to TYPO3 Core - Task #59775: Cleanup FormEngine Closed 2014-09-26

Associated revisions

Revision 8eb6b3f5 (diff)
Added by Sebastian Michaelsen over 5 years ago

[CLEANUP] Clean code in FormEngine

\TYPO3\CMS\Backend\Form\FormEngine could use a few cleanups:

  • Import some classes to avoid unnecessary fully qualified class names
  • Fix some PHPdoc issues
  • Slightly adjust some method signatures
    (when 0, 1, or '' were used for boolean information)
  • Remove some unused local variables

Resolves: #58995
Releases: 6.3, 6.2
Change-Id: Ic79acf80e75b78f9b8b70c946dd15e5b32996fb2
Reviewed-on: https://review.typo3.org/30252
Reviewed-by: Markus Klein
Tested-by: Markus Klein

Revision faa7bdb6 (diff)
Added by Sebastian Michaelsen over 5 years ago

[CLEANUP] Clean code in FormEngine

\TYPO3\CMS\Backend\Form\FormEngine could use a few cleanups:

  • Import some classes to avoid unnecessary fully qualified class names
  • Fix some PHPdoc issues
  • Slightly adjust some method signatures
    (when 0, 1, or '' were used for boolean information)
  • Remove some unused local variables

Resolves: #58995
Releases: 6.3, 6.2
Change-Id: Ic79acf80e75b78f9b8b70c946dd15e5b32996fb2
Reviewed-on: https://review.typo3.org/31016
Reviewed-by: Markus Klein
Tested-by: Markus Klein

History

#1 Updated by Gerrit Code Review over 5 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/30252

#2 Updated by Gerrit Code Review over 5 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/30252

#3 Updated by Gerrit Code Review over 5 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/30252

#4 Updated by Gerrit Code Review over 5 years ago

Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/31016

#5 Updated by Anonymous over 5 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#6 Updated by Benni Mack about 1 year ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF