Bug #59035
closed"[BUGFIX] Fix possible language handling issue" break formhandler ajax functionality
0%
Description
Hi Markus,
sorry for assign you directly... This request target the bug-report #49499 with the [BUGFIX] "Fix possible language handling issue" from you.
The problem in detail:
We use the EXT:formhandler with AJAX-handling for our forms in TYPO3 v6.x. In this example with the latest v6.1. This site is multi-language (DE, AT, CH, EN). In all language-files (XML, XLF) the default language is EN.
If I call of page with a formula in German (DE), the form looks good. But if I submit it and the AJAX call is fired, the form become English after exchange. All labels read from default language of the locallang.xml (from formhandler).
Indeed I was a little bit shocked after the update to TYPO3 v6.1.8. =D
So I researched this problem...
In "/typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php" you moved this code "$this->initLLvars();" from line 2419 to line 2501:
https://review.typo3.org/#/c/27664/2/typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php
If I revert only this little change and the forms work as aspected again. And now I hope for some help. Do you have any suggestion for me. Actually I'm not an active contribute but a silent reader. ;-)
Best regard,
David
P.S. If it's an option, we can talk in German. ^^
Updated by Markus Klein over 10 years ago
- Category set to Backend API
- Priority changed from Should have to Must have
- Is Regression changed from No to Yes
Thanks for the report. Investigating this.
Btw: the definition of an "active contributor" can be found here:
http://typo3.org/teams/core-development-team/roles-groups/
Updated by Markus Klein over 10 years ago
Are you sure that just moving the $this->initLLvars();
back to its original position solves the problem?
Actually I've no clue why this should make much of a difference.
The call order in index_ts.php is
$TSFE->getConfigArray(); // Setting language and locale $TT->push('Setting language and locale', ''); $TSFE->settingLanguage();
The $this->initLLvars();
call was placed near the end of $TSFE->getConfigArray();
and was moved to the beginning of $TSFE->settingLanguage();
.
So what happens in formhandler that this makes a difference?
Updated by David Gurk over 10 years ago
Hi,
thanks for this quick reply.
Yes I only move this single line of code in TYPO3 v6.1.9 core. I leave the order in index_ts.php
// After this, we should have a valid config-array ready $TSFE->getConfigArray(); // Setting language and locale $TT->push('Setting language and locale', ''); $TSFE->settingLanguage();
I'm not sure what exactly happens in formhandler. I'm try to investigating in this extension.
Updated by David Gurk over 10 years ago
I try to create a simple test suite next week. You hear from me. =)
Updated by David Gurk over 10 years ago
So I testet a lot. It seems, that formhandler fixes this bug with the newest update (2.0.0 from ter).
Updated by David Gurk over 10 years ago
And thanks for your time. This issue can be closed
Updated by Markus Klein over 10 years ago
- Status changed from New to Closed
- Assignee deleted (
Markus Klein) - Is Regression changed from Yes to No