Task #59132
closed
Move GenralUtility::isFirstPartOfStr() to StringUtility::isFirstPartOfStr()
100%
Description
It's very confusing when looking for string operations and you find only the function isLastPartOfString() in StringUtility. So I didn't expect any other string operations, but then i found my needed function isFirstPartOfStr() in GenralUtility?! Maybe there are more string operations that should move to StringUtility.
Updated by Markus Klein almost 10 years ago
Hi Tobias!
Yes our swiss army knife GeneralUtility holds way too many functions. But we didn't touch functions like isFirstPartOfStr() because they are in place for a very long time and are used a lot.
So a solution would be to duplicate it for the StringUtility class. Don't know when the time is right to deprecate it from GeneralUtility.
Updated by Tobias Braumann almost 10 years ago
That make senses! Then duplicate is maybe a good solution for now. So people have time to change from GeneralUtility to StringUtility.
Updated by Gerrit Code Review almost 10 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/30611
Updated by Gerrit Code Review almost 10 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/30611
Updated by Gerrit Code Review almost 10 years ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/30611
Updated by Gerrit Code Review almost 10 years ago
Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/30611
Updated by Gerrit Code Review almost 10 years ago
Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/30611
Updated by Gerrit Code Review almost 10 years ago
Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/30611
Updated by Gerrit Code Review almost 10 years ago
Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/30611
Updated by Gerrit Code Review almost 10 years ago
Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/30611
Updated by Gerrit Code Review almost 10 years ago
Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/30611
Updated by Markus Klein almost 10 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 5110012201ff2a51fc099d3de9d0053bed6f08b6.
Updated by Riccardo De Contardi over 6 years ago
- Status changed from Resolved to Closed