Task #59132: Move GenralUtility::isFirstPartOfStr() to StringUtility::isFirstPartOfStr() - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Task #59132

closed

Move GenralUtility::isFirstPartOfStr() to StringUtility::isFirstPartOfStr()

Added by Tobias Braumann over 10 years ago. Updated about 7 years ago.

Status:

Closed

Priority:

Must have

Assignee:

Category:

Backend API

Target version:

7.0

Start date:

2014-05-27

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

6.2

PHP Version:

Tags:

Complexity:

no-brainer

Sprint Focus:

Description

It's very confusing when looking for string operations and you find only the function isLastPartOfString() in StringUtility. So I didn't expect any other string operations, but then i found my needed function isFirstPartOfStr() in GenralUtility?! Maybe there are more string operations that should move to StringUtility.

Related issues 1 (0 open — 1 closed)

Actions

Copy link

Updated by Markus Klein over 10 years ago

Hi Tobias!

Yes our swiss army knife GeneralUtility holds way too many functions. But we didn't touch functions like isFirstPartOfStr() because they are in place for a very long time and are used a lot.
So a solution would be to duplicate it for the StringUtility class. Don't know when the time is right to deprecate it from GeneralUtility.

Actions

Copy link

Updated by Tobias Braumann over 10 years ago

That make senses! Then duplicate is maybe a good solution for now. So people have time to change from GeneralUtility to StringUtility.

Actions

Copy link

Updated by Gerrit Code Review over 10 years ago

Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/30611

Actions

Copy link

Updated by Gerrit Code Review over 10 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/30611

Actions

Copy link

Updated by Gerrit Code Review over 10 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/30611

Actions

Copy link

Updated by Gerrit Code Review over 10 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/30611

Actions

Copy link

Updated by Gerrit Code Review over 10 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/30611

Actions

Copy link

Updated by Gerrit Code Review over 10 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/30611

Actions

Copy link

Updated by Gerrit Code Review over 10 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/30611

Actions

Copy link

#10

Updated by Gerrit Code Review over 10 years ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/30611

Actions

Copy link

#11

Updated by Gerrit Code Review over 10 years ago

Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/30611

Actions

Copy link

#12