Bug #59495

set_no_cache log severity detection uses invalid $GLOBALS array key

Added by Alexander Stehlik almost 6 years ago. Updated over 1 year ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Frontend
Target version:
-
Start date:
2014-06-11
Due date:
% Done:

100%

TYPO3 Version:
6.2
PHP Version:
Tags:
Complexity:
no-brainer
Is Regression:
No
Sprint Focus:

Description

The error is quite obvious. If a Backend user is logged in the log level for the set_no_cache() call in the TypoScriptFrontendController should be reduced.

This is the current code:

if ($internal && isset($GLOBALS['BE_USER]'])) {

As you can see, there is a duplicate closing brace used inside the array key.


Related issues

Related to TYPO3 Core - Feature #43735: Reduce severity for set_no_cache() from core Closed 2012-12-07

Associated revisions

Revision 92907937 (diff)
Added by Alexander Stehlik almost 6 years ago

[BUGFIX] Fix set_no_cache() log level severity

The array key that is used to check if a Backend user is logged in
is fixed.

Resolves: #59495
Releases: 6.2
Change-Id: Ida6609c3bde998e17a0d9e9184adb48f227507f5
Reviewed-on: https://review.typo3.org/30663
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring

History

#1 Updated by Gerrit Code Review almost 6 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/30663

#2 Updated by Alexander Stehlik almost 6 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#3 Updated by Benni Mack over 1 year ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF