Project

General

Profile

Actions

Bug #59608

closed

displayEditIcons error with tt_content.mailform

Added by Dominik Weber almost 10 years ago. Updated over 8 years ago.

Status:
Rejected
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2014-06-16
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
6.2
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

If i use a typoscript object path like lib.test and apply tt_content.mailform to it, I get a catchable php error because the fifth parameter to the displayEditIcons-function is NULL but needs to be an array.

I fixed it manually in line 127 of typo3/sysext/core/Classes/FrontendEditing/FrontendEditingController.php from
public function displayEditIcons($content, $params, array $conf = array(), $currentRecord = '', array $dataArray = array(), $addUrlParamStr = '') {

to

public function displayEditIcons($content, $params, array $conf = array(), $currentRecord = '', $dataArray = array(), $addUrlParamStr = '') {

Can we apply this to the core?

Actions #1

Updated by Mathias Schreiber over 8 years ago

  • Status changed from New to Rejected

No sorry, this cannot be done because this will now work for non-admin users.
DataArray is getting passed around quite often and most of the following methods rely on this.

Actions #2

Updated by Björn Jacob over 8 years ago

Furthermore there is no need to do something like @lib.test < tt_content.mailform. If you want to create a form based on TypoScript just use the FORM object and it's form objects like TEXTLINE or TEXTAREA or whatever you need. If you have questions on how to create a form just using TS get in touch with me on Slack.

Actions

Also available in: Atom PDF