Bug #59655

Fatal JS Error in elementBrowser with %

Added by DANIEL Rémy almost 6 years ago. Updated over 1 year ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2014-06-18
Due date:
% Done:

100%

TYPO3 Version:
6.2
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

TYPO3 6.2.3

When I select an item from the element browser (or from the autocomplete wizard), and if the item contains a % (percent), I get a JS error :

URIError: malformed URI sequence

The error happens in typo3/sysext/backend/Resources/Public/JavaScript/FormEngine.js at the line 131.
I really don't know why decodeURI is used here...

So I reworked the part where the option is created and inserted in the DOM, so that we can get rid of decodeURI.

I will submit a review soon.

Associated revisions

Revision d944c070 (diff)
Added by DANIEL Rémy almost 6 years ago

[BUGFIX] Fix a JS error in with TCE select wizard

Fixes an exception with decodeURI when an item containing
a % (percent) character is added to a select.
jQuery is now only used to append the option and its label to the DOM.

Resolves: #59655
Releases: 6.3, 6.2
Change-Id: I245f2fbec347b7e149aeea1cb7148591dc47e6f8
Reviewed-on: https://review.typo3.org/30896
Reviewed-by: Tim Lochmüller
Tested-by: Tim Lochmüller
Reviewed-by: Markus Klein
Tested-by: Markus Klein

Revision 27b5433a (diff)
Added by DANIEL Rémy almost 6 years ago

[BUGFIX] Fix a JS error in with TCE select wizard

Fixes an exception with decodeURI when an item containing
a % (percent) character is added to a select.
jQuery is now only used to append the option and its label to the DOM.

Resolves: #59655
Releases: 6.3, 6.2
Change-Id: I245f2fbec347b7e149aeea1cb7148591dc47e6f8
Reviewed-on: https://review.typo3.org/30821
Reviewed-by: Markus Klein
Tested-by: Markus Klein

History

#1 Updated by Gerrit Code Review almost 6 years ago

  • Status changed from New to Under Review

Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/30821

#2 Updated by Gerrit Code Review almost 6 years ago

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/30896

#3 Updated by Gerrit Code Review almost 6 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/30896

#4 Updated by Gerrit Code Review almost 6 years ago

Patch set 2 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/30821

#5 Updated by DANIEL Rémy almost 6 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#6 Updated by Benni Mack over 1 year ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF