Project

General

Profile

Actions

Task #59771

closed

Change be_sessions:ses_data field from LONGTEXT to TEXT

Added by Michiel Roos almost 10 years ago. Updated over 9 years ago.

Status:
Rejected
Priority:
Should have
Assignee:
-
Category:
Code Cleanup
Target version:
-
Start date:
2014-06-21
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
6.2
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

The ses_data field of the be_sessions table has always been LONGTEXT.

This breaks TYPO3 sessions when running under hhvm: https://notes.typo3.org/p/hhvm

The field started out as a blob field. Later it changed to a mediumblob, then into a mediumtext before finally turning into a longtext back in 2007.

So great! Now the field can hold 4GB of data :-)

But it breaks hhvm.

We can safely change it to a text field. That will hold 64K of data. And as you all know even 4k should be enough for everyone: http://blog.hvidtfeldts.net/index.php/2007/11/4k-should-be-enough-for-everyone/

But all jokes aside, the field may hold 21.844 in a worst case (3 byte UTF-8 characters: http://stackoverflow.com/questions/4420164/how-much-utf-8-text-fits-in-a-mysql-text-field).

Actions #1

Updated by Jose Antonio Guerra almost 10 years ago

See related info on GitHub issue (read this comment and below): https://github.com/facebook/hhvm/issues/2377#issuecomment-46751747

Actions #2

Updated by Gerrit Code Review over 9 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35732

Actions #3

Updated by Wouter Wolters over 9 years ago

  • Status changed from Under Review to Resolved
Actions #4

Updated by Markus Klein over 9 years ago

  • Status changed from Resolved to Rejected

The patch was reverted with https://review.typo3.org/35762

The ticket is rejected as the storage size is needed for workspaces, which uses quite some session memory.

Actions

Also available in: Atom PDF