Bug #60549

Get GeneralUtility::getIndpEnv in ContentObjectRenderer mockable

Added by Sascha Egerer almost 5 years ago. Updated 3 months ago.

Status:
Under Review
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2014-07-25
Due date:
% Done:

100%

TYPO3 Version:
6.2
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

There are several calls to GeneralUtility::getIndpEnv() in the ContentObjectRenderer. These calls can not be mocked which prevents clean unit tests.


Related issues

Related to TYPO3 Core - Bug #58702: f:uri.page Viewhelper creates broken links on cli Rejected 2014-05-12

Associated revisions

Revision ebcbf634 (diff)
Added by Sascha Egerer almost 5 years ago

[TASK] Add wrapper for GeneralUtility::getIndpEnv in ContentObjectRenderer

A wrapper function for GeneralUtility::getIndpEnv() is required
to mock these static calls in unit tests.

Resolves: #60549
Releases: 6.3, 6.2
Change-Id: I47b565f5a5bd9b2445847d38447c01cfa20954c7
Reviewed-on: http://review.typo3.org/31788
Reviewed-by: Oliver Klee <>
Reviewed-by: Christian Kuhn <>
Tested-by: Christian Kuhn <>
Reviewed-by: Markus Klein <>
Tested-by: Markus Klein <>

Revision 5de7287b (diff)
Added by Sascha Egerer almost 5 years ago

[TASK] Add wrapper for GeneralUtility::getIndpEnv in ContentObjectRenderer

A wrapper function for GeneralUtility::getIndpEnv() is required
to mock these static calls in unit tests.

Resolves: #60549
Releases: 6.3, 6.2
Change-Id: I47b565f5a5bd9b2445847d38447c01cfa20954c7
Reviewed-on: http://review.typo3.org/31792
Reviewed-by: Markus Klein <>
Tested-by: Markus Klein <>

History

#1 Updated by Gerrit Code Review almost 5 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/31788

#2 Updated by Gerrit Code Review almost 5 years ago

Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/31792

#3 Updated by Anonymous almost 5 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#4 Updated by Mathias Brodala almost 5 years ago

This change now actually makes it possible to simulate environment variables for e.g. creating frontent URIs with the Extbase UriBuilder in backend/CLI, see #58702.

#5 Updated by Benni Mack 10 months ago

  • Status changed from Resolved to Closed

#6 Updated by Gerrit Code Review 3 months ago

  • Status changed from Closed to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60566

Also available in: Atom PDF