Project

General

Profile

Actions

Bug #60549

closed

Get GeneralUtility::getIndpEnv in ContentObjectRenderer mockable

Added by Sascha Egerer over 9 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2014-07-25
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
6.2
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

There are several calls to GeneralUtility::getIndpEnv() in the ContentObjectRenderer. These calls can not be mocked which prevents clean unit tests.


Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Bug #58702: f:uri.page Viewhelper creates broken links on cliRejected2014-05-12

Actions
Actions #1

Updated by Gerrit Code Review over 9 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/31788

Actions #2

Updated by Gerrit Code Review over 9 years ago

Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/31792

Actions #3

Updated by Anonymous over 9 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #4

Updated by Mathias Brodala over 9 years ago

This change now actually makes it possible to simulate environment variables for e.g. creating frontent URIs with the Extbase UriBuilder in backend/CLI, see #58702.

Actions #5

Updated by Benni Mack over 5 years ago

  • Status changed from Resolved to Closed
Actions #6

Updated by Gerrit Code Review almost 5 years ago

  • Status changed from Closed to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60566

Actions #7

Updated by Andreas Kienast over 4 years ago

  • Status changed from Under Review to Closed
Actions

Also available in: Atom PDF