Project

General

Profile

Actions

Feature #61577

closed

Feature #61471: Base EXT: t3skin on twbs less

Use HTML5 label+checkbox semantics

Added by Felix Kopp almost 10 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2014-09-14
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

There is no common mark-up in the CMS backend for checkbox+labels in forms.
With the inclusion of Bootstrap we decide for the Bootstrap HTML5 markup syntax in forms:

See http://getbootstrap.com/css/#forms for preview and mark-up.

Forms do not receive a special markup.
Normal forms without layout (not horizontal, not filter-bar, not inline) include this syntax:

<form role="form">

  <div class="form-group">
    <label for="text">Label text</label>
    <input type="file" id="text">
    <p class="help-block">Example block-level help text here.</p>
  </div>

  <div class="checkbox">
    <label>
      <input type="checkbox">
      Check me out
    </label>
  </div>

</form>

In this first step we migrate the checkbox html towards HTML5 mark-up:

  1. Wrap checkbox group within
    <div class="checkbox"></div>
  2. Move Input field into the
    <label>…</label>
  3. Move the label text into the
    <label>…</label>
    after the input checkbox

Why?
Ofter the checkbox and radio inputs are grouped and bring one description label for the group:

Behave like: [x] A
[-] B

Therefore the <label> tag is not formatted bold and the

<div class="checkbox">
can also bring another group label.


Files

select-field-input-group.jpeg (120 KB) select-field-input-group.jpeg Felix Kopp, 2014-09-14 16:53

Subtasks 3 (0 open3 closed)

Task #61579: Use HTML5 label+checkbox semanticsClosedFrank Nägler2014-09-14

Actions
Bug #61581: HTML 5 checkbox + label in Functions -> Create multipleClosed2014-09-14

Actions
Task #61584: [TASK] Fix more broken checkbox for Bootstrap changeClosedFrank Nägler2014-09-14

Actions
Actions #2

Updated by Gerrit Code Review almost 10 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/32762

Actions #3

Updated by Felix Kopp almost 10 years ago

These are the places I found more checkboxes:

+ Functions module / CreatePagesWizardModuleFunctionController / lines 130ff.
+ Info PageTS / InfoPageTyposcriptConfigController / lines ~70

Actions #4

Updated by Felix Kopp almost 10 years ago

Checkbox

+ Edit record / FormEngine
+ Template

Actions #5

Updated by Frank Nägler almost 10 years ago

+ Filelist > File listing
+ Backend User > Editi BE User > "Show secondary options (palettes)"

both will be fixed in https://forge.typo3.org/issues/61579

Actions #6

Updated by Gerrit Code Review almost 10 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/32762

Actions #7

Updated by Gerrit Code Review almost 10 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/32762

Actions #8

Updated by Gerrit Code Review almost 10 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/32762

Actions #9

Updated by Felix Kopp almost 10 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #10

Updated by Benni Mack over 5 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF