Bug #61699

Epic #58282: Workspaces Workpackage #2

Story #58284: Bug fixes & Behaviour

Workspace Preview not working with lockSSL=3

Added by Oliver Hader about 5 years ago. Updated about 1 year ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
Miscellaneous
Target version:
Start date:
2014-09-18
Due date:
% Done:

100%

TYPO3 Version:
6.2
PHP Version:
5.3
Tags:
Complexity:
medium
Is Regression:
Yes
Sprint Focus:

Description

The workspace preview does not work with lockSSL=3 being defined in the Install Tool. First it looks like a CSS issue, in the end it boils down that the preview IFRAMEs are not correctly initialized in \TYPO3\CMS\Workspaces\Hook\TypoScriptFrontendControllerHook. The mentioned hook is only called once for the request to the first IFRAME showing the website frontend preview and won't be called for further.

The reason is, that cache expire headers are sent that prevent the client to update the preview on each preview request. That's why the mentioned hook is not called and the IFRAMEs are not initialized properly. No-Cache headers are sent if a backend user object is initialized correctly - and that's the actual bug, a wrong but strict PHP condition, comparing a string (lockSSL) with an integer value.

The comparison flaw was integrated with issue #54265


Related issues

Related to TYPO3 Core - Task #54265: Use (int) instead of intval() or (integer) Closed 2013-12-07
Related to TYPO3 Core - Bug #61374: Workspace Preview unusable due to size Closed 2014-09-05
Related to TYPO3 Core - Bug #61376: Workspace Preview does not toggle between Live and Workspace Closed 2014-09-05
Related to TYPO3 Core - Bug #51687: Page Preview not working with LockSSLPort Closed 2013-09-03

Associated revisions

Revision ede69ff6 (diff)
Added by Oliver Hader about 5 years ago

[BUGFIX] Workspace Preview not working with lockSSL=3

The workspace preview does not work with lockSSL=3 being defined
in the Install Tool. First it looks like a CSS issue, in the end
it boils down that the preview IFRAMEs are not correctly
initialized in Workspaces\Hook\TypoScriptFrontendControllerHook.

The mentioned hook is only called once for the request to the
first IFRAME showing the website frontend preview and won't be
called for further.

The reason is, that cache expire headers are sent that prevent
the client to update the preview on each preview request.
That's why the mentioned hook is not called and the IFRAMEs
are not initialized properly. No-Cache headers are sent if a
backend user object is initialized correctly - and that's the
actual bug, a wrong but strict PHP condition, comparing a string
(lockSSL) with an integer value.

The comparison flaw was integrated with issue #54265

Change-Id: I13c5c2f22f5b43b49f8eead88f1bc82daf415cbb
Resolves: #61699
Releases: master, 6.2
Reviewed-on: http://review.typo3.org/32851
Reviewed-by: Wouter Wolters <>
Reviewed-by: Markus Klein <>
Tested-by: Markus Klein <>
Reviewed-by: Oliver Hader <>
Tested-by: Oliver Hader <>

Revision 9c0ba3a9 (diff)
Added by Oliver Hader about 5 years ago

[BUGFIX] Workspace Preview not working with lockSSL=3

The workspace preview does not work with lockSSL=3 being defined
in the Install Tool. First it looks like a CSS issue, in the end
it boils down that the preview IFRAMEs are not correctly
initialized in Workspaces\Hook\TypoScriptFrontendControllerHook.

The mentioned hook is only called once for the request to the
first IFRAME showing the website frontend preview and won't be
called for further.

The reason is, that cache expire headers are sent that prevent
the client to update the preview on each preview request.
That's why the mentioned hook is not called and the IFRAMEs
are not initialized properly. No-Cache headers are sent if a
backend user object is initialized correctly - and that's the
actual bug, a wrong but strict PHP condition, comparing a string
(lockSSL) with an integer value.

The comparison flaw was integrated with issue #54265

Change-Id: I13c5c2f22f5b43b49f8eead88f1bc82daf415cbb
Resolves: #61699
Releases: master, 6.2
Reviewed-on: http://review.typo3.org/32857
Reviewed-by: Oliver Hader <>
Tested-by: Oliver Hader <>

History

#1 Updated by Gerrit Code Review about 5 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/32851

#2 Updated by Gerrit Code Review about 5 years ago

Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/32857

#3 Updated by Oliver Hader about 5 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#4 Updated by Oliver Hader about 5 years ago

  • Parent task set to #58284

#5 Updated by Benni Mack about 1 year ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF