Project

General

Profile

Actions

Bug #62147

closed

TCA eval 'email' for validating e-mail addresses

Added by Olle Haerstedt over 9 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Should have
Category:
-
Target version:
Start date:
2014-10-10
Due date:
% Done:

100%

Estimated time:
2.00 h
TYPO3 Version:
6.2
PHP Version:
5.3
Tags:
Complexity:
easy
Is Regression:
No
Sprint Focus:

Description

Add an additional 'eval' option for the TCA: email. This will validate
that the entered value is a valid e-mail address using PHP FILTER_VALIDATE_EMAIL.
If the e-mail is not valid, a flash error message will show.


Related issues 1 (0 open1 closed)

Is duplicate of TYPO3 Core - Feature #15147: TCA: possibility to evaluate email fieldsClosed2005-10-22

Actions
Actions #1

Updated by Gerrit Code Review over 9 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/33251

Actions #2

Updated by Gerrit Code Review over 9 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/33251

Actions #3

Updated by Gerrit Code Review over 9 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/33251

Actions #4

Updated by Gerrit Code Review over 9 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/33251

Actions #5

Updated by Georg Ringer over 9 years ago

I would be in favor of waiting a bit because we are planing to add all of those HTML5 input options to the FormEngine which makes it possible to have this feature out of the box!

Actions #6

Updated by Gerrit Code Review over 9 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/33251

Actions #7

Updated by Gerrit Code Review over 9 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/33251

Actions #8

Updated by Gerrit Code Review over 9 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/33251

Actions #9

Updated by Gerrit Code Review over 9 years ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/33251

Actions #10

Updated by Gerrit Code Review over 9 years ago

Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/33251

Actions #11

Updated by Gerrit Code Review over 9 years ago

Patch set 10 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/33251

Actions #12

Updated by Gerrit Code Review over 9 years ago

Patch set 11 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/33251

Actions #13

Updated by Gerrit Code Review over 9 years ago

Patch set 12 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/33251

Actions #14

Updated by Gerrit Code Review over 9 years ago

Patch set 13 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/33251

Actions #15

Updated by Gerrit Code Review over 9 years ago

Patch set 14 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/33251

Actions #16

Updated by Gerrit Code Review over 9 years ago

Patch set 15 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/33251

Actions #17

Updated by Patrick Schriner over 9 years ago

None of the old "eval" options output a flashmessage. I know it doesn't look as nice, but without the flash message code (which looks a lot like duplicate code in the same class anyway) the code would be much simpler:

 if (!GeneralUtility::validEmail($value)) {
     $set = FALSE;
     $value = '';
 }

Furthermore the method checkValue_input_Eval is public. You can't be for sure that someone isn't using this to do some evaluation and doesn't expect output in form of a flash message.

Actions #18

Updated by Gerrit Code Review over 9 years ago

Patch set 16 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/33251

Actions #19

Updated by Olle Haerstedt over 9 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #20

Updated by Benni Mack over 5 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF