Bug #62205

jsfunc.inline.js is not fully jQuery compatible

Added by Stefan Froemken over 6 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Should have
Category:
Backend User Interface
Target version:
Start date:
2014-10-13
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
7
PHP Version:
5.5
Tags:
Complexity:
medium
Is Regression:
No
Sprint Focus:

Description

Hello Core-Team,

there are multiple parts in jsfunc.inline.js where you try to access subobjects directly on a jQuery-object.

Example: If you have "var selectBox = jQuery('#selectId');" you will get a jQuery-init-object which contains the selectbox with id #selectId as array on ID 0
So if you want to access the selectbox now, you have to call "selectBox0".

I would to prefer to add all jQuery-Objects a $ in front to differ them from all the "normal" JS-Objects.

Stefan

#1

Updated by Gerrit Code Review over 6 years ago

  • Status changed from New to Under Review

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/33302

#2

Updated by Markus Klein over 6 years ago

I agree. This is common practise in JS.

#3

Updated by Gerrit Code Review over 6 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/33302

#4

Updated by Gerrit Code Review over 6 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/33302

#5

Updated by Gerrit Code Review over 6 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/33302

#6

Updated by Stefan Froemken over 6 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#7

Updated by Riccardo De Contardi over 3 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF