Project

General

Profile

Actions

Bug #62245

closed

Extension installer: Handle multiple blanks

Added by Martin Bless over 9 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Must have
Assignee:
-
Category:
-
Target version:
-
Start date:
2014-10-15
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
4.5
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

The parser of the ext_tables.sql file removes double blanks from the input line - but only once. So if there are multiple blanks at least double blanks remain and irritate the later comparison about whether the field definition is different.

Problem:
Line 508 in TYPO3.CMS/t3lib/class.t3lib_install.php:

   $lineV = str_replace('  ', ' ', $lineV); // Remove double blanks

Solution:
Line 508 in TYPO3.CMS/t3lib/class.t3lib_install.php:

   $lineV = preg_replace('/[ ][ ]+/', ' ', $lineV); // Remove multiple blanks

I'll (try to) submit this solution as a patch now on review.typo3.org.


Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Bug #64627: Extension installer: Handle multiple blanksClosed2015-01-30

Actions
Actions #1

Updated by Gerrit Code Review over 9 years ago

  • Status changed from New to Under Review

Patch set 1 for branch TYPO3_4-5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/33318

Actions #2

Updated by Gerrit Code Review over 9 years ago

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/33321

Actions #3

Updated by Gerrit Code Review over 9 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/33321

Actions #4

Updated by Gerrit Code Review over 9 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/33321

Actions #5

Updated by Gerrit Code Review over 9 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/33321

Actions #6

Updated by Gerrit Code Review over 9 years ago

Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/33841

Actions #7

Updated by Stefan Froemken over 9 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #8

Updated by Martin Bless over 9 years ago

Wow,

I am impressed. Thank you all very much for bugfixing. This reassures me that reporting a bug really pays out!

H.A.N.D. - have a nice day!

Actions #9

Updated by Benni Mack over 5 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF