Bug #62245
closedExtension installer: Handle multiple blanks
100%
Description
The parser of the ext_tables.sql file removes double blanks from the input line - but only once. So if there are multiple blanks at least double blanks remain and irritate the later comparison about whether the field definition is different.
Problem:
Line 508 in TYPO3.CMS/t3lib/class.t3lib_install.php:
$lineV = str_replace(' ', ' ', $lineV); // Remove double blanks
Solution:
Line 508 in TYPO3.CMS/t3lib/class.t3lib_install.php:
$lineV = preg_replace('/[ ][ ]+/', ' ', $lineV); // Remove multiple blanks
I'll (try to) submit this solution as a patch now on review.typo3.org.
Updated by Gerrit Code Review about 10 years ago
- Status changed from New to Under Review
Patch set 1 for branch TYPO3_4-5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/33318
Updated by Gerrit Code Review about 10 years ago
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/33321
Updated by Gerrit Code Review about 10 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/33321
Updated by Gerrit Code Review about 10 years ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/33321
Updated by Gerrit Code Review about 10 years ago
Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/33321
Updated by Gerrit Code Review about 10 years ago
Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/33841
Updated by Stefan Froemken about 10 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset a15f39f3f8eb3410241e8e940809e76c2d3404e9.
Updated by Martin Bless about 10 years ago
Wow,
I am impressed. Thank you all very much for bugfixing. This reassures me that reporting a bug really pays out!
H.A.N.D. - have a nice day!