Bug #62245
closed
Extension installer: Handle multiple blanks
Added by Martin Bless about 10 years ago.
Updated about 6 years ago.
Description
The parser of the ext_tables.sql file removes double blanks from the input line - but only once. So if there are multiple blanks at least double blanks remain and irritate the later comparison about whether the field definition is different.
Problem:
Line 508 in TYPO3.CMS/t3lib/class.t3lib_install.php:
$lineV = str_replace(' ', ' ', $lineV); // Remove double blanks
Solution:
Line 508 in TYPO3.CMS/t3lib/class.t3lib_install.php:
$lineV = preg_replace('/[ ][ ]+/', ' ', $lineV); // Remove multiple blanks
I'll (try to) submit this solution as a patch now on review.typo3.org.
- Status changed from New to Under Review
Patch set 1 for branch TYPO3_4-5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/33318
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/33321
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/33321
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/33321
Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/33321
Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/33841
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Wow,
I am impressed. Thank you all very much for bugfixing. This reassures me that reporting a bug really pays out!
H.A.N.D. - have a nice day!
- Status changed from Resolved to Closed
Also available in: Atom
PDF