Project

General

Profile

Actions
Copy link

Bug #62463

closed

bug in compressing the css-files!?

Added by Kurt Kunig about 10 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Must have
Assignee:
-
Category:
Backend API
Target version:
-
Start date:
2014-10-25
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
6.2
PHP Version:
5.3
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

TYPO3 V6.2 maybe a bug in compressing the css-files!?

e.g.: A css3 parameter like width: calc(100% + 16px); does not appear in the compressed CSS-file when config.compressCss is set to 1!

Setting the parameter to config.compressCss = 0, the "calc"-item will be there!

Related issues 4 (0 open — 4 closed)

Related to TYPO3 Core - Bug #64950: Regex in RessourceCompressor triggers PHP segfault with old pcre versionsClosed2015-02-09

Actions
Related to TYPO3 Core - Bug #69309: config.compressCss breaks CSS3 calc() valueClosed2015-08-25

Actions
Related to TYPO3 Core - Bug #69648: Built-in css minification destroys certain CSS constructsClosed2015-09-10

Actions
Has duplicate TYPO3 Core - Bug #78361: bug in compressing the css-files againRejected2016-10-20

Actions
Actions
Copy link
 #1

Updated by Christian Futterlieb about 10 years ago

I experienced similar behaviour with following difference: the compressor removes the whitespaces, which results in an invalid rule:

width: calc(100% + 16px);

becomes:
width: calc(100%+16px);

But "+" and "-" must be wrapped with whitespaces: http://www.w3.org/TR/2006/WD-css3-values-20060919/#calc

I digged around in the compressor and will push a possible solution

Actions
Copy link
 #2

Updated by Gerrit Code Review about 10 years ago

  • Status changed from New to Under Review

Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/34180

Actions
Copy link
 #3

Updated by Gerrit Code Review almost 10 years ago

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35366

Actions
Copy link
 #4

Updated by Gerrit Code Review almost 10 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35366

Actions
Copy link
 #5

Updated by Gerrit Code Review almost 10 years ago

Patch set 2 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/34180

Actions
Copy link
 #6

Updated by Christian Futterlieb almost 10 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions
Copy link
 #7

Updated by Christian Kuhn almost 10 years ago

This patch leads to PHP segfaults on PHP versions with older PCRE versions. It will be reverted in #64950 for 6.2 for now, and master will get a PCRE version check in install tool.

Please see the related issue for more details.

This patch could potentially be fixed again in 6.2 if a regex can be found that does not crash php ...

Actions
Copy link
 #8

Updated by Benni Mack about 6 years ago

  • Status changed from Resolved to Closed
Actions
Copy link

Also available in: Atom PDF