Actions
Bug #62532
closedIndexedSearch pagination wrong because of strict comparison
Start date:
2014-10-29
Due date:
% Done:
100%
Estimated time:
TYPO3 Version:
7
PHP Version:
5.5
Tags:
Complexity:
Is Regression:
Yes
Sprint Focus:
Description
The pagination of indexed_search is broken because the strict comparison compares a float with an integer and that will never be true.
Code looks like
$pointer = (int)$this->piVars['pointer']; $minPage = $pointer - floor($maxPages / 2); for ($a = $minPage; $a <= $maxPage; $a++) { if ($a === $pointer) { // Never true } }
Updated by Gerrit Code Review almost 10 years ago
- Status changed from Accepted to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/33605
Updated by Gerrit Code Review almost 10 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/33605
Updated by Gerrit Code Review almost 10 years ago
Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/33606
Updated by Georg Ringer almost 10 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 62cff46f97b1749884860db74e3cf88c3179ebde.
Updated by Riccardo De Contardi almost 7 years ago
- Status changed from Resolved to Closed
Actions