Project

General

Profile

Actions

Bug #62532

closed

IndexedSearch pagination wrong because of strict comparison

Added by Georg Ringer over 9 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Must have
Assignee:
Category:
Indexed Search
Target version:
Start date:
2014-10-29
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
7
PHP Version:
5.5
Tags:
Complexity:
Is Regression:
Yes
Sprint Focus:

Description

The pagination of indexed_search is broken because the strict comparison compares a float with an integer and that will never be true.

Code looks like

$pointer = (int)$this->piVars['pointer'];
$minPage = $pointer - floor($maxPages / 2);
for ($a = $minPage; $a <= $maxPage; $a++) {
if ($a === $pointer) {
// Never true
}
}


Related issues 2 (0 open2 closed)

Related to TYPO3 Core - Bug #60346: indexed_search experimental mode returns negative values in page browserClosed2014-07-15

Actions
Precedes TYPO3 Core - Bug #63350: IndexedSearch pagination wrong in extbase and classic viewClosedMarkus Klein2014-11-26

Actions
Actions #1

Updated by Gerrit Code Review over 9 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/33605

Actions #2

Updated by Gerrit Code Review over 9 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/33605

Actions #3

Updated by Gerrit Code Review over 9 years ago

Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/33606

Actions #4

Updated by Georg Ringer over 9 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #5

Updated by Riccardo De Contardi over 6 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF