Task #62782

"No RDCT-Workaround" in fe_login is now unused

Added by Patrick Kroog about 5 years ago. Updated about 1 year ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2014-11-08
Due date:
% Done:

100%

TYPO3 Version:
6.2
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

The TS setting "config.notification_email_urlmode" [1] is not respected by the method "$cObj->sendNotifyEmail" [2] in TYPO3 6.2.

Therefore the "fe_login No RDCT-Workaround", which disables the URL-shortening for the "Retrieve-Lost-Password-Mail" is unused:

// no RDCT - Links for security reasons
$oldSetting = $GLOBALS['TSFE']->config['config']['notification_email_urlmode'];
$GLOBALS['TSFE']->config['config']['notification_email_urlmode'] = 0;
// Send the email
$this->cObj->sendNotifyEmail($msg, $user['email'], '', $this->conf['email_from'], $this->conf['email_fromName'], $this->conf['replyTo']);
// Restore settings
$GLOBALS['TSFE']->config['config']['notification_email_urlmode'] = $oldSetting;

Formerly in TYPO3 4.5 $GLOBALS['TSFE']->plainMailEncoded finally sent the "Retrieve-Lost-Password-Mail", which is now deprecated and seems to be the only core method, which still uses the above TS setting [3] and the URL-shortening core method [4]

A commit removing the unused bits already exists [5]

[1] Documentation of TS-Setting: http://docs.typo3.org/typo3cms/TyposcriptReference/Setup/Config/Index.html#notification-email-urlmode

[2] $cObj->sendNotifyEmail: https://git.typo3.org/Packages/TYPO3.CMS.git/blob/a34edf6b58cd8d799a67fb20c1a67bff6aa374e9:/typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php#l6729

[3] Deprecated $GLOBALS['TSFE']->plainMailEncoded: http://typo3.org/api/typo3cms/class_t_y_p_o3_1_1_c_m_s_1_1_core_1_1_utility_1_1_general_utility.html#aeeb5389db76f39a2d4179dfc3a1f1544

[4] GeneralUtility::substUrlsInPlainText http://typo3.org/api/typo3cms/class_t_y_p_o3_1_1_c_m_s_1_1_core_1_1_utility_1_1_general_utility.html#afd3da7a2a25c754d3701bd5f833048e3

[5] https://review.typo3.org/#/c/23658/


Related issues

Related to TYPO3 Core - Task #62793: Remove last bits of config.notification_* Closed 2014-11-09
Related to TYPO3 Core - Bug #62794: Deprecate old mail related methods in GeneralUtility Closed 2014-11-09

Associated revisions

Revision 0ff01a9c (diff)
Added by Patrick Kroog about 5 years ago

[TASK] Remove "no RDCT"-workaround in fe_users Forgot-Password mail

As the used method sendNotifyEmail doesnt substitute URLs
with \TYPO3\CMS\Core\Utility\GeneralUtility::substUrlsInPlainText
the former workaround for security reasons is not needed.

Resolves: #62782
Releases: master
Change-Id: Ie7d57cd3e1925c6442982c87b53f3a5ee8feb6e0
Reviewed-on: http://review.typo3.org/23658
Reviewed-by: Christian Kuhn <>
Tested-by: Christian Kuhn <>
Reviewed-by: Benjamin Mack <>
Tested-by: Benjamin Mack <>

Revision 515a6880 (diff)
Added by Christian Kuhn about 5 years ago

[TASK] Remove last bits of config.notification_*

Some TypoScript parameter were used in the old mail
handling and are now obsolete after latest deprecation
removals. The patch removes last bits of:

config.notification_email_charset
config.notification_email_encoding
config.notification_email_urlmode

Change-Id: I5d584a244e55407d6c98011e705f110c0eaf1f53
Resolves: #62793
Related: #62782
Releases: master
Reviewed-on: http://review.typo3.org/33919
Reviewed-by: Benjamin Mack <>
Tested-by: Benjamin Mack <>
Reviewed-by: Christian Kuhn <>
Tested-by: Christian Kuhn <>

History

#1 Updated by Gerrit Code Review about 5 years ago

  • Status changed from New to Under Review

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/23658

#2 Updated by Patrick Kroog about 5 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#3 Updated by Benni Mack about 1 year ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF