Task #62782
closed"No RDCT-Workaround" in fe_login is now unused
100%
Description
The TS setting "config.notification_email_urlmode" [1] is not respected by the method "$cObj->sendNotifyEmail" [2] in TYPO3 6.2.
Therefore the "fe_login No RDCT-Workaround", which disables the URL-shortening for the "Retrieve-Lost-Password-Mail" is unused:
// no RDCT - Links for security reasons $oldSetting = $GLOBALS['TSFE']->config['config']['notification_email_urlmode']; $GLOBALS['TSFE']->config['config']['notification_email_urlmode'] = 0; // Send the email $this->cObj->sendNotifyEmail($msg, $user['email'], '', $this->conf['email_from'], $this->conf['email_fromName'], $this->conf['replyTo']); // Restore settings $GLOBALS['TSFE']->config['config']['notification_email_urlmode'] = $oldSetting;
Formerly in TYPO3 4.5 $GLOBALS['TSFE']->plainMailEncoded finally sent the "Retrieve-Lost-Password-Mail", which is now deprecated and seems to be the only core method, which still uses the above TS setting [3] and the URL-shortening core method [4]
A commit removing the unused bits already exists [5]
[1] Documentation of TS-Setting: http://docs.typo3.org/typo3cms/TyposcriptReference/Setup/Config/Index.html#notification-email-urlmode
[2] $cObj->sendNotifyEmail: https://git.typo3.org/Packages/TYPO3.CMS.git/blob/a34edf6b58cd8d799a67fb20c1a67bff6aa374e9:/typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php#l6729
[3] Deprecated $GLOBALS['TSFE']->plainMailEncoded: http://typo3.org/api/typo3cms/class_t_y_p_o3_1_1_c_m_s_1_1_core_1_1_utility_1_1_general_utility.html#aeeb5389db76f39a2d4179dfc3a1f1544
[4] GeneralUtility::substUrlsInPlainText http://typo3.org/api/typo3cms/class_t_y_p_o3_1_1_c_m_s_1_1_core_1_1_utility_1_1_general_utility.html#afd3da7a2a25c754d3701bd5f833048e3
Updated by Gerrit Code Review about 10 years ago
- Status changed from New to Under Review
Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/23658
Updated by Patrick Kroog about 10 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 0ff01a9c8b18d896d67fe5f6e5feae067a25f565.