Project

General

Profile

Actions

Bug #63070

closed

ADOdb: mssqlnative driver does not properly define the port

Added by Manuel Schneider over 9 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Must have
Assignee:
-
Category:
Database API (Doctrine DBAL)
Target version:
Start date:
2014-11-19
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
6.2
PHP Version:
Tags:
Complexity:
easy
Is Regression:
No
Sprint Focus:

Description

One of our extension has a depency on the adodb extension.

This extension connect to a mssql (Microsoft SQL 2005) server. If the connection use the default port (1433) there is no problem. But my dns string look like this:
mssql://user:password@192.168.1.1:12345/databasename

After I try to connect I get an error with the message

coult not connect to server 192.168.1.1 ....

The port is missing. After a little debugging I found the bug. In file typo3/sysext/adodb/adodb/adodb.inc.php on line 4378 the adodb class try to connect with the function $this->Connect

$ok = $obj->Connect($dsna['host'], $dsna['user'], $dsna['pass'], $dsna['path']);

As you can see the port is missing, after inserting the port it works

$ok = $obj->Connect($dsna['host'] . ':' . $dsna['port'], $dsna['user'], $dsna['pass'], $dsna['path']);

Actions #1

Updated by Philipp Gampe over 9 years ago

  • Status changed from New to Accepted

Looks like a bug in adodb. We should check if there is an update and fix it ourself if not.

Actions #2

Updated by Manuel Schneider over 9 years ago

Hello Philipp. I have also created a ticket in on github a few days ago
https://github.com/ADOdb/ADOdb/issues/58

Actions #3

Updated by Markus Bischof over 9 years ago

+1

I also voted up the ticket at GitHub

Actions #4

Updated by Xavier Perseguers almost 9 years ago

  • Subject changed from sysext adodb ignore the port (mssql) to ADOdb: mssqlnative driver does not properly define the port

Fixing using mssqlnative driver, hope it is fine with you.

Actions #5

Updated by Gerrit Code Review almost 9 years ago

  • Status changed from Accepted to Under Review

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39324

Actions #6

Updated by Gerrit Code Review almost 9 years ago

Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39335

Actions #7

Updated by Xavier Perseguers almost 9 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #8

Updated by Benni Mack over 5 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF