Project

General

Profile

Actions
Copy link

Bug #63131

closed

Wrong encoded TitleTags/Umlaute in Feedit

Added by Sven Juergens almost 10 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
Candidate for patchlevel
Start date:
2014-11-21
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
6.2
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

hi,

There is a bug with titleTags in german in feedit: "Neuen Datensatz einfügen" or have a look at the attached image.
The FrontendEdit Panel us $GLOBALS['BE_USER']->extGetLL('xxx')); to get the correct translations.

In this function is a call to "$labelStr = $this->getLanguageService()->csConvObj->utf8_to_entities($labelStr);", why we need to convert to entities ?
If the HTML output ist UTF8 there is no reason to use it and convert it. especially with "UTF8 everywhere" in mind.

Solution could be to remove this call in FrontendBackendUserAuthentication.php -> function extGetLL()

Files

Download all files
feedit.PNG (4.11 KB) feedit.PNG Sven Juergens, 2014-11-21 16:41
2016-01-26 typo3 feedit popup confirm.png (13 KB) 2016-01-26 typo3 feedit popup confirm.png Christian Weiske, 2016-01-26 16:18

Related issues 1 (0 open — 1 closed)

Has duplicate TYPO3 Core - Bug #19806: wrong encoded String from class.t3lib_tsfebeuserauth.phpClosed2009-01-13

Actions
Actions
Copy link
 #1

Updated by Sven Juergens almost 10 years ago

P.S. to reproduce this bug, install a fresh TYPO3 6.2.6, install EXT:feedit, download the german translations, switch your Backend Language to German and activate feedit

Actions
Copy link
 #2

Updated by Chris topher over 9 years ago

I see this bug as well.

In the backend of TYPO3 6.2 and newer, charsets other than UTF-8 are no longer supported. The backend charset will be UTF-8 anyway. So there is no need to convert entities.

The fix is to remove the call to utf8_to_entities(). This fixes the issue.

Actions
Copy link
 #3

Updated by Riccardo De Contardi about 9 years ago

the line

$labelStr = $this->getLanguageService()->csConvObj->utf8_to_entities($labelStr);

is still present inside typo3/sysext/backend/Classes/FrontendBackendUserAuthentication.php on both 6.2.15 and 7.6-dev (latest master)

Actions
Copy link
 #4

Updated by Riccardo De Contardi almost 9 years ago

  • Target version set to Candidate for patchlevel
Actions
Copy link
 #5

Updated by Gerrit Code Review almost 9 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/46247

Actions
Copy link
 #6

Updated by Gerrit Code Review almost 9 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/46247

Actions
Copy link
 #7

Updated by Christian Weiske almost 9 years ago

Also happens in confirmation popup dialogs - see screenshot.

Actions
Copy link
 #8

Updated by Gerrit Code Review almost 9 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/46247

Actions
Copy link
 #9

Updated by Gerrit Code Review almost 9 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/46247

Actions
Copy link
 #10

Updated by Gerrit Code Review over 8 years ago

Patch set 1 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/46802

Actions
Copy link
 #11

Updated by Anonymous over 8 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions
Copy link
 #12

Updated by Benni Mack about 6 years ago

  • Status changed from Resolved to Closed
Actions
Copy link

Also available in: Atom PDF