Bug #63670
closedBug #63692: Memory consumption while bulk inserting
High memory consumption in DataHandler->checkValue_input while bulk inserting
100%
Description
In DataHandler->checkValue_input for each input value of each record to insert is executed.
// Process evaluation settings: $evalCodesArray = GeneralUtility::trimExplode(',', $tcaFieldConf['eval'], TRUE);
While this may seem minor introducing a cache here helps:
public function checkValue_input($res, $value, $tcaFieldConf, $PP, $field = '') { static $evalCodesCache = array(); [...] // Process evaluation settings: if ($evalCodesCache[$tcaFieldConf['eval']]) { $evalCodesArray = $evalCodesCache[$tcaFieldConf['eval']]; } else { $evalCodesArray = GeneralUtility::trimExplode(',', $tcaFieldConf['eval'], TRUE); $evalCodesCache[$tcaFieldConf['eval']] = $evalCodesArray; }For bulk inserting of 6500 records:
- 2 calls instead of 44646 to trimExplode from this function
- 0.7 sec faster
- memory_usage of trimExplode down by 17MB
Files
Updated by Gerrit Code Review about 10 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35186
Updated by Gerrit Code Review about 10 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35186
Updated by Gerrit Code Review about 10 years ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35186
Updated by Gerrit Code Review about 10 years ago
Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35186
Updated by Gerrit Code Review about 10 years ago
Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35186
Updated by Gerrit Code Review about 10 years ago
Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35186
Updated by Gerrit Code Review about 10 years ago
Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35186
Updated by Gerrit Code Review almost 10 years ago
Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35186
Updated by Gerrit Code Review almost 10 years ago
Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35186
Updated by Gerrit Code Review almost 10 years ago
Patch set 10 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35186
Updated by Gerrit Code Review almost 10 years ago
Patch set 11 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35186
Updated by Gerrit Code Review almost 10 years ago
Patch set 12 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35186
Updated by Gerrit Code Review almost 10 years ago
Patch set 13 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35186
Updated by Gerrit Code Review almost 10 years ago
Patch set 14 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35186
Updated by Gerrit Code Review almost 10 years ago
Patch set 15 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35186
Updated by Stephan Großberndt over 9 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 5acee1d3cec4dd807d41800a9bc4b82faf80286c.
Updated by Gerrit Code Review over 9 years ago
- Status changed from Resolved to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/37937
Updated by Gerrit Code Review over 9 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/37937
Updated by Gerrit Code Review over 9 years ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/37937
Updated by Nicole Cordes over 9 years ago
- Status changed from Under Review to Resolved
Applied in changeset 4a9e5fdb0f5ef41f5eed88200b906a4a800300b4.
Updated by Gerrit Code Review over 9 years ago
- Status changed from Resolved to Under Review
Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/37963
Updated by Stephan Großberndt over 9 years ago
- Status changed from Under Review to Resolved
Applied in changeset c1bb6311afc3477e449460193eda3a6c6826d38d.
Updated by Christian Kuhn 10 months ago
- Related to Task #103125: Stop runtime caching GU::trimExplode() in DH added