Project

General

Profile

Actions
Copy link

Bug #63713

closed

Check fields for NOT NULL by default in getDatabaseExtra()

Added by Stephan Großberndt almost 10 years ago. Updated about 7 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Install Tool
Target version:
7.4 (Backend)
Start date:
2014-12-09
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
7
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

The current default definition of getDatabaseExtra() in typo3/sysext/install/Classes/Service/SqlSchemaMigrationService.php is $ignoreNotNullWhenComparing = TRUE.

public function getDatabaseExtra($FDsrc, $FDcomp, $onlyTableList = '', $ignoreNotNullWhenComparing = TRUE) {

This means even if a definition in ext_tables.sql is

my_int_field int(10) unsigned NOT NULL DEFAULT '0',
my_varchar_field varchar(255) NOT NULL DEFAULT '',

TYPO3 currently does not force the field to be NOT NULL. If NOT NULL is in the field definition of a table in ext_tables.sql, TYPO3 should respect this and force the field to be NOT NULL by default.

If there are DBAL issues, check for installation of dbal and changing of $ignoreNotNullWhenComparing should be done in getDatabaseExtra()

Related issues 1 (0 open — 1 closed)

Is duplicate of TYPO3 Core - Bug #64616: Compare Database does not remove 'NOT NULL'Closed2015-01-29

Actions
Actions
Copy link

Also available in: Atom PDF