Bug #63728
closedBug #63692: Memory consumption while bulk inserting
Unnecessary calls to BackendUtility->getTCAtypeValue in DataHandler->fillInFieldArray
100%
Description
- is_array($types_fieldConfig)
- !$this->dontProcessTransformations
- isset($fieldArray[$vconf['field']])
- (string) $incomingFieldArray[('_TRANSFORM_' . $vconf['field'])] == 'RTE'
// Checking for RTE-transformations of fields: $types_fieldConfig = BackendUtility::getTCAtypes($table, $currentRecord); $theTypeString = BackendUtility::getTCAtypeValue($table, $currentRecord); if (is_array($types_fieldConfig)) { foreach ($types_fieldConfig as $vconf) { // Write file configuration: // inserted array_merge($currentRecord,$fieldArray) 170502 $eFile = \TYPO3\CMS\Core\Html\RteHtmlParser::evalWriteFile($vconf['spec']['static_write'], array_merge($currentRecord, $fieldArray)); // RTE transformations: if (!$this->dontProcessTransformations) { if (isset($fieldArray[$vconf['field']])) { // Look for transformation flag: switch ((string) $incomingFieldArray[('_TRANSFORM_' . $vconf['field'])]) { case 'RTE': $RTEsetup = $this->BE_USER->getTSConfig('RTE', BackendUtility::getPagesTSconfig($tscPID)); $thisConfig = BackendUtility::RTEsetup($RTEsetup['properties'], $table, $vconf['field'], $theTypeString);
Instead of calling this function unconditionally it should only be called if a first RTE with transformations is detected and be cached then.
Updated by Gerrit Code Review almost 10 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35227
Updated by Gerrit Code Review almost 10 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35227
Updated by Stephan Großberndt almost 10 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset f6c06bc3dc6c61d3b2b5204ebb7a0ea40828008d.
Updated by Gerrit Code Review almost 10 years ago
- Status changed from Resolved to Under Review
Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/37575
Updated by Stephan Großberndt almost 10 years ago
- Status changed from Under Review to Resolved
Applied in changeset 9f462369487049371d480c6c744b3943ac2860da.