Bug #63733: Do not call recordInfo() for new records in DataHandler->checkValue - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Bug #63733

closed

Bug #63692: Memory consumption while bulk inserting

Do not call recordInfo() for new records in DataHandler->checkValue

Added by Stephan Großberndt almost 10 years ago. Updated about 6 years ago.

Status:

Closed

Priority:

Should have

Assignee:

Category:

Performance

Target version:

next-patchlevel

Start date:

2014-12-10

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

6.2

PHP Version:

Tags:

Complexity:

easy

Is Regression:

Sprint Focus:

Description

Currently DataHandler->checkValue calls

// Get current value:
$curValueRec = $this->recordInfo($table, $id, $field);
$curValue = $curValueRec[$field];

even for new records ($id = 'NEW...')

When bulk inserting 6500 records checking the id before calling recordInfo saves 5MB of RAM:

if (!(int)$id) {
    $curValue = NULL;
} else {
    // Get current value:
    $curValueRec = $this->recordInfo($table, $id, $field);
    $curValue = $curValueRec[$field];
}

Actions

Copy link

Updated by Gerrit Code Review almost 10 years ago

Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35237

Actions

Copy link

Updated by Wouter Wolters almost 10 years ago

Parent task set to #63692

Actions

Copy link

Updated by Gerrit Code Review almost 10 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35237

Actions

Copy link

Updated by Gerrit Code Review almost 10 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35237

Actions

Copy link

Updated by Gerrit Code Review almost 10 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35237

Actions

Copy link

Updated by Gerrit Code Review almost 10 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35237

Actions

Copy link

Updated by Gerrit Code Review almost 10 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35237

Actions

Copy link

Updated by Gerrit Code Review almost 10 years ago

Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/36595

Actions

Copy link