Project

General

Profile

Actions
Copy link

Bug #63733

closed

Bug #63692: Memory consumption while bulk inserting

Do not call recordInfo() for new records in DataHandler->checkValue

Added by Stephan Großberndt over 9 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Performance
Target version:
next-patchlevel
Start date:
2014-12-10
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
6.2
PHP Version:
Tags:
Complexity:
easy
Is Regression:
No
Sprint Focus:

Description

Currently DataHandler->checkValue calls

// Get current value:
$curValueRec = $this->recordInfo($table, $id, $field);
$curValue = $curValueRec[$field];

even for new records ($id = 'NEW...')

When bulk inserting 6500 records checking the id before calling recordInfo saves 5MB of RAM:

if (!(int)$id) {
    $curValue = NULL;
} else {
    // Get current value:
    $curValueRec = $this->recordInfo($table, $id, $field);
    $curValue = $curValueRec[$field];
}

Actions
Copy link

Also available in: Atom PDF