Bug #63750: Avoid calling getUserObj in DataHandler->checkValue_input_Eval - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Bug #63750

closed

Bug #63692: Memory consumption while bulk inserting

Avoid calling getUserObj in DataHandler->checkValue_input_Eval

Added by Stephan Großberndt over 9 years ago. Updated over 5 years ago.

Status:

Closed

Priority:

Should have

Assignee:

Category:

Performance

Target version:

next-patchlevel

Start date:

2014-12-10

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

6.2

PHP Version:

Tags:

Complexity:

easy

Is Regression:

Sprint Focus:

Description

If the eval field is empty in a TCA input definition there is no NULL or empty check:

default:
    $evalObj = GeneralUtility::getUserObj($GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['tce']['formevals'][$func] . ':&' . $func);
    if (is_object($evalObj) && method_exists($evalObj, 'evaluateFieldValue')) {
        $value = $evalObj->evaluateFieldValue($value, $is_in, $set);
    }

If $func is empty, this leads to a call to unnecessary call to GeneralUtility::getUserObj(':&');

Actions

Copy link

Updated by Mathias Schreiber over 9 years ago

Parent task set to #63692

Actions

Copy link

Updated by Gerrit Code Review over 9 years ago

Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35287

Actions

Copy link

Updated by Gerrit Code Review over 9 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35287

Actions

Copy link

Updated by Gerrit Code Review over 9 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35287

Actions

Copy link

Updated by Gerrit Code Review over 9 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35287

Actions

Copy link

Updated by Gerrit Code Review over 9 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35287

Actions

Copy link

Updated by Gerrit Code Review over 9 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35287

Actions

Copy link

Updated by Gerrit Code Review over 9 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35287

Actions

Copy link

Updated by Gerrit Code Review over 9 years ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35287

Actions

Copy link

#10

Updated by Gerrit Code Review over 9 years ago

Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35287

Actions

Copy link

#11

Updated by Gerrit Code Review over 9 years ago

Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/36188

Actions

Copy link

#12