Bug #63974

CSS concatination and compression failes with font

Added by Armin Vieweg over 5 years ago. Updated over 1 year ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2014-12-18
Due date:
% Done:

100%

TYPO3 Version:
6.2
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

When using font in css like this:

.whatever {
    font:12px/15px 'Alright Sans Alt', Verdana, Sans;
}
it breakes after concatination and compression and looks like:
.whatever {
    font:12px/15px'Alright Sans Alt',Verdana,Sans;
}
The difference is slightly, all spaces has been removed. Unfortunately also the spaces after the line-height. All browsers are able to compensate this wrong css, except IE (tested with 8-11).

A work arround is to split this line to its single definitions:

.whatever {
    font-size: 12px;
    line-height: 15px;
    font-family: 'Alright Sans Alt', Verdana, Sans;
}
But of course it would be better if the compressor would keep the spaces in this case.


Related issues

Related to TYPO3 Core - Bug #60675: CSS compressor is removing white spaces (font directive) Closed 2014-07-30

Associated revisions

Revision b47d65e9 (diff)
Added by Andreas Fernandez almost 5 years ago

[TASK] Update CSS compressor

The old CSS compressor had some issues with certain CSS definitions.
Update the optimizer from upstream and deprecate the
compressCssPregCallback method.

Resolves: #63974
Related: #62463, #60675
Releases: master
Change-Id: Ibe37b902aafd41685042e37485623531e3e8e46c
Reviewed-on: http://review.typo3.org/35565
Reviewed-by: Markus Klein <>
Tested-by: Markus Klein <>
Reviewed-by: Stefan Neufeind <>
Tested-by: Stefan Neufeind <>

History

#1 Updated by Gerrit Code Review over 5 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35565

#2 Updated by Gerrit Code Review over 5 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35565

#3 Updated by Gerrit Code Review over 5 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35565

#4 Updated by Gerrit Code Review over 5 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35565

#5 Updated by Gerrit Code Review over 5 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35565

#6 Updated by Gerrit Code Review about 5 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35565

#7 Updated by Gerrit Code Review about 5 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35565

#8 Updated by Gerrit Code Review about 5 years ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35565

#9 Updated by Gerrit Code Review about 5 years ago

Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35565

#10 Updated by Gerrit Code Review almost 5 years ago

Patch set 10 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35565

#11 Updated by Gerrit Code Review almost 5 years ago

Patch set 11 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35565

#12 Updated by Gerrit Code Review almost 5 years ago

Patch set 12 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35565

#13 Updated by Gerrit Code Review almost 5 years ago

Patch set 13 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35565

#14 Updated by Gerrit Code Review almost 5 years ago

Patch set 14 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35565

#15 Updated by Gerrit Code Review almost 5 years ago

Patch set 15 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35565

#16 Updated by Gerrit Code Review almost 5 years ago

Patch set 16 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35565

#17 Updated by Andreas Fernandez almost 5 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#18 Updated by Benni Mack over 1 year ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF