Project

General

Profile

Actions

Bug #64273

closed

Downloading FAL media via FileDumpEID.php causes an out of memory error

Added by Klaus Moser almost 10 years ago. Updated about 7 years ago.

Status:
Closed
Priority:
Must have
Assignee:
-
Category:
File Abstraction Layer (FAL)
Target version:
Start date:
2015-01-14
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
6.2
PHP Version:
Tags:
Complexity:
easy
Is Regression:
No
Sprint Focus:

Description

When trying to download a large file (in my case a mp4 file) via FileDumpEID.php i get an out of memory error. The file is sent by the method dumpFileContents in class TYPO3\CMS\Core\Resource\Driver\LocalDriver. According to PHP manual the method readfile will not present any memory issues when output buffering is off, so i checked ob_get_level() in TYPO3\CMS\Core\Resource\ResourceStorage->dumpFileContents and for any reason it was 3.
Maybe it would be a good idea to disable output buffering before using readfile().

@public function dumpFileContents(FileInterface $file, $asDownload = FALSE, $alternativeFilename = NULL) {

[...]
while (ob_get_level() > 0) {
ob_end_clean();
}
$this->driver->dumpFileContents($file->getIdentifier());

}@


Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Bug #64330: dumpFileContents does not work as intended when compression is enabledClosed2015-01-17

Actions
Actions #1

Updated by Mathias Schreiber almost 10 years ago

  • Target version set to 7.1 (Cleanup)
  • Sprint Focus set to On Location Sprint
Actions #2

Updated by Ingo Schmitt almost 10 years ago

  • Complexity set to easy
Actions #3

Updated by Gerrit Code Review almost 10 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/36485

Actions #4

Updated by Gerrit Code Review almost 10 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/36485

Actions #5

Updated by Gerrit Code Review almost 10 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/36485

Actions #6

Updated by Gerrit Code Review almost 10 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/36485

Actions #7

Updated by Gerrit Code Review almost 10 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/36485

Actions #8

Updated by Gerrit Code Review almost 10 years ago

Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/36533

Actions #9

Updated by Roman Schürmann almost 10 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #10

Updated by Anja Leichsenring almost 9 years ago

  • Sprint Focus deleted (On Location Sprint)
Actions #11

Updated by Riccardo De Contardi about 7 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF