Task #64326

Story #64327: Unit test compatibility with HHVM

AbstractConditionMatcherTest run on HHVM

Added by Tymoteusz Motylewski over 6 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Should have
Category:
-
Target version:
-
Start date:
2015-01-17
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
7
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

AbstractConditionMatcherTest contains unnecessary method mocking
which is breaking the test in HHVM

1) TYPO3\CMS\Core\Tests\Unit\Configuration\TypoScript\ConditionMatching\AbstractConditionMatcherTest::evaluateConditionCommonReturnsTrueForMatchingContexts with data set #0 ('Production*')
Failed asserting that null is true.

hhvm/hphp/test/frameworks/framework_downloads/typo3/typo3/sysext/core/Tests/Unit/Configuration/TypoScript/ConditionMatching/AbstractConditionMatcherTest.php:91
hhvm/hphp/test/frameworks/framework_downloads/typo3/Packages/Libraries/phpunit/phpunit/phpunit:62

#1

Updated by Tymoteusz Motylewski over 6 years ago

  • Parent task set to #64327
#2

Updated by Gerrit Code Review over 6 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/36058

#3

Updated by Gerrit Code Review over 6 years ago

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/36058

#4

Updated by Tymoteusz Motylewski over 6 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#5

Updated by Benni Mack over 2 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF