Bug #64535

Suppress useCombination warning for certain fields

Added by Andreas Allacher almost 5 years ago. Updated over 1 year ago.

Status:
Closed
Priority:
Should have
Category:
-
Target version:
-
Start date:
2015-01-27
Due date:
% Done:

100%

TYPO3 Version:
6.2
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

It would be nice to suppress the useCombination warning for certain fields.

demoinline.zip (8.37 KB) Andreas Allacher, 2015-01-30 13:33

Warning Message.png View - warning message (26.6 KB) Andreas Allacher, 2015-01-30 13:33

suppressed_warning.png View - suppressed warning message (23.7 KB) Andreas Allacher, 2015-01-30 13:33

Associated revisions

Revision c1025c56 (diff)
Added by Andreas Allacher over 4 years ago

[FEATURE] IRRE useCombination option to modify warning text

Add support for inline elements in combination with
['appearance']['useCombination'] to suppress the warning
messages by using ['appearance']['suppressCombinationWarning']
or ['appearance']['overwriteCombinationWarningMessage'] to
overwrite the default message.
(allows LLL: values)

Change-Id: I0765b9316cdfa9e09eb6eaf4e366c9470bfb7d75
Resolves: #64535
Releases: master
Reviewed-on: http://review.typo3.org/36415
Reviewed-by: Daniel Goerz <>
Tested-by: Daniel Goerz <>
Reviewed-by: Christian Kuhn <>
Tested-by: Christian Kuhn <>

Revision c346e9bd (diff)
Added by Christian Kuhn over 4 years ago

[FOLLOWUP][FEATURE] IRRE useCombination option to modify warning text

Fix a fatal and a typo.

Resolves: #64535
Releases: master
Change-Id: I4a04c6482675dbd07771a8e3e2f5659f9360cebe
Reviewed-on: http://review.typo3.org/42314
Reviewed-by: Anja Leichsenring <>
Tested-by: Anja Leichsenring <>
Reviewed-by: Daniel Goerz <>
Tested-by: Daniel Goerz <>
Reviewed-by: Andreas Fernandez <>
Tested-by: Andreas Fernandez <>

Revision cc6f805b (diff)
Added by Andreas Fernandez over 4 years ago

[FOLLOWUP][FEATURE] IRRE useCombination option to modify warning text

Fix headline of ReST document.

Resolves: #64535
Releases: master
Change-Id: I624841144b68e8311e6b5034ff4c8660dcbe4666
Reviewed-on: http://review.typo3.org/42315
Reviewed-by: Daniel Goerz <>
Tested-by: Daniel Goerz <>
Reviewed-by: Morton Jonuschat <>
Tested-by: Morton Jonuschat <>
Reviewed-by: Andreas Fernandez <>
Tested-by: Andreas Fernandez <>

History

#1 Updated by Mathias Schreiber almost 5 years ago

  • Status changed from New to Needs Feedback
  • Assignee set to Mathias Schreiber

Could you add some info to the report?
I have troubles understanding what you refer to :)

#2 Updated by Andreas Allacher almost 5 years ago

Sorry.
I meant if I use a TCA configuration for an inline field in combination with the appearance setting useCombination.
The foreign_selector record will that way be rendered as inline field.

However, that way I get a warning when editing the record that it is edited "globally" which makes sense in a way but might not be necessary all the time.

Furthermore, if one mainly uses it to render the foreign_selector record (it is necessary to create the intermediate table to use foreign_selector)
and suppress all fields in the intermediate table then I have an empty line from not used tabs of the record of the intermediate table.

I mean the message in \TYPO3\CMS\Backend\Form\Element\InlineElement::renderCombinationTable:

    $flashMessage = GeneralUtility::makeInstance('TYPO3\\CMS\\Core\\Messaging\\FlashMessage', $GLOBALS['LANG']->sL('LLL:EXT:lang/locallang_core.xlf:warning.inline_use_combination'), '', FlashMessage::WARNING);
            $out = $flashMessage->render();

#3 Updated by Gerrit Code Review almost 5 years ago

  • Status changed from Needs Feedback to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/36415

#4 Updated by Andreas Allacher almost 5 years ago

Demo EXT and possible solution added.

Though it might also be a good idea to not only suppress but also allow to modify the message.

#5 Updated by Gerrit Code Review almost 5 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/36415

#6 Updated by Gerrit Code Review almost 5 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/36415

#7 Updated by Gerrit Code Review over 4 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/36415

#8 Updated by Gerrit Code Review over 4 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/36415

#9 Updated by Gerrit Code Review over 4 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/36415

#10 Updated by Gerrit Code Review over 4 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/36415

#11 Updated by Andreas Allacher over 4 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#12 Updated by Gerrit Code Review over 4 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/42314

#13 Updated by Gerrit Code Review over 4 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/42314

#14 Updated by Christian Kuhn over 4 years ago

  • Status changed from Under Review to Resolved

#15 Updated by Gerrit Code Review over 4 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/42315

#16 Updated by Andreas Fernandez over 4 years ago

  • Status changed from Under Review to Resolved

#17 Updated by Benni Mack over 1 year ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF