Project

General

Profile

Actions

Bug #64621

closed

FAL relation could be created even if the filetype is not allowed for the TCA field

Added by Sascha Egerer almost 10 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
File Abstraction Layer (FAL)
Target version:
-
Start date:
2015-01-29
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
6.2
PHP Version:
Tags:
Complexity:
hard
Is Regression:
No
Sprint Focus:

Description

It is possible to create a FAL file relation even if the file extension is not allowed for this field.

Reproduce:
  1. Create a new image element
  2. Modify the "Add Image" button (using firebug e.g.) from something like
    setFormValueOpenBrowser('file', '|||gif,jpg,jpeg,tif,tiff,bmp,pcx,tga,png,pdf,ai|data-38-tt_content-173-image-sys_file_reference|inline.checkUniqueElement||inline.importElement'); return false;
    to
    setFormValueOpenBrowser('file', '||||data-38-tt_content-173-image-sys_file_reference|inline.checkUniqueElement||inline.importElement'); return false;
  3. Click on open Image. You'll now be able to select any kind of file.
  4. select a non image file
  5. The file is visually added to the content element
  6. Save the record

Result:
You won't see that the records has been added what is the expected behavior.
But it is added. The relation is created in the database but not displayed in TCA as the file extension is not allowed.

Expected Result:
The relation should never be created by checking the file extension before creating the relation.


Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Bug #64619: Different behavior of allowed filename for adminsClosed2015-01-29

Actions
Actions #1

Updated by Sascha Egerer almost 10 years ago

  • Description updated (diff)
Actions #2

Updated by Sascha Egerer almost 10 years ago

It looks like this is only possible for Admins. Maybe it is related to #64619

Actions #3

Updated by Ingo Schmitt almost 10 years ago

  • Complexity set to hard
Actions #4

Updated by Armin Vieweg almost 10 years ago

The relation is created in the database but not displayed in TCA as the file extension is not allowed.

The relation is created, but got deleted=1.

Actions #5

Updated by Sascha Egerer almost 10 years ago

Armin Ruediger Vieweg wrote:

The relation is created in the database but not displayed in TCA as the file extension is not allowed.

The relation is created, but got deleted=1.

Ok. But it should not be created anyway...

Actions #6

Updated by Armin Vieweg almost 10 years ago

But you are able to undelete the relation. It will not displayed in backend, but it is still there. Even updating the record, even changing other relations, have no effect to the undeleted relation.

Actions #7

Updated by Sascha Egerer almost 10 years ago

  • Status changed from Accepted to In Progress
Actions #8

Updated by Gerrit Code Review almost 10 years ago

  • Status changed from In Progress to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/36496

Actions #9

Updated by Gerrit Code Review almost 10 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/36496

Actions #10

Updated by Gerrit Code Review almost 10 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/36496

Actions #11

Updated by Gerrit Code Review almost 10 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/36496

Actions #12

Updated by Gerrit Code Review almost 10 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/36496

Actions #13

Updated by Gerrit Code Review almost 10 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/36496

Actions #14

Updated by Gerrit Code Review almost 10 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/36496

Actions #15

Updated by Armin Vieweg almost 10 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #16

Updated by Anja Leichsenring almost 9 years ago

  • Sprint Focus deleted (On Location Sprint)
Actions #17

Updated by Benni Mack about 6 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF