Bug #64710

sysext\form\Tests\Unit\Filter\StripNewLinesFilterTest fails on Windows

Added by Stephan GroƟberndt over 4 years ago. Updated almost 2 years ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
Tests
Target version:
Start date:
2015-02-01
Due date:
% Done:

100%

TYPO3 Version:
7
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

There were 2 failures:

1) TYPO3\CMS\Form\Tests\Unit\Filter\StripNewLinesFilterTest::filterForStringWithNewlineReturnsStringWithoutNewline with
data set "some^Mtext" ('some\ntext', 'some text')
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-some text
+some  text

D:\typo3\master\typo3\sysext\form\Tests\Unit\Filter\StripNewLinesFilterTest.php:55
D:\typo3\master\Packages\Libraries\phpunit\phpunit\phpunit:62

2) TYPO3\CMS\Form\Tests\Unit\Filter\StripNewLinesFilterTest::filterForStringWithNewlineReturnsStringWithoutNewline with
data set "trailing newline^M" ('trailing newline\n', 'trailing newline ')
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-trailing newline
+trailing newline

D:\typo3\master\typo3\sysext\form\Tests\Unit\Filter\StripNewLinesFilterTest.php:55
D:\typo3\master\Packages\Libraries\phpunit\phpunit\phpunit:62

Associated revisions

Revision db8c98c6 (diff)
Added by Ronny Vorpahl over 4 years ago

[BUGFIX] Enhancing StripNewLinesFilter for Windows line breaks

Currently the filter does not handle Windows line breaks.
This results in unfiltered Windows line breaks.
This patch adds Windows line break support to the filter function.
Furthermore the unit tests for the filter are extended to check
Windows line breaks as well.

Resolves: #64710
Releases: master,6.2
Change-Id: I503657daaf693f1a28589bc7d8a9321ebae54e61
Reviewed-on: http://review.typo3.org/36564
Reviewed-by: Oliver Klee <>
Tested-by: Oliver Klee <>
Reviewed-by: Nicole Cordes <>
Tested-by: Nicole Cordes <>
Reviewed-by: Anja Leichsenring <>
Tested-by: Anja Leichsenring <>

Revision b023f6e9 (diff)
Added by Ronny Vorpahl over 4 years ago

[BUGFIX] Enhancing StripNewLinesFilter for Windows line breaks

Currently the filter does not handle Windows line breaks.
This results in unfiltered Windows line breaks.
This patch adds Windows line break support to the filter function.
Furthermore the unit tests for the filter are extended to check
Windows line breaks as well.

Resolves: #64710
Releases: master, 6.2
Change-Id: I503657daaf693f1a28589bc7d8a9321ebae54e61
Reviewed-on: http://review.typo3.org/36578
Reviewed-by: Jigal van Hemert <>
Tested-by: Jigal van Hemert <>

History

#1 Updated by Ronny Vorpahl over 4 years ago

  • Assignee set to Ronny Vorpahl

#2 Updated by Nicole Cordes over 4 years ago

  • Assignee changed from Ronny Vorpahl to Nicole Cordes

#3 Updated by Nicole Cordes over 4 years ago

  • Status changed from New to Accepted
  • Assignee changed from Nicole Cordes to Ronny Vorpahl

#4 Updated by Gerrit Code Review over 4 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/36564

#5 Updated by Ronny Vorpahl over 4 years ago

The unit tests failed cause you checked out your sources using Windows line break style. This is configurable in the global Git settings.
Use the command "git config --global core.autocrlf input" to change this behavior.

#6 Updated by Gerrit Code Review over 4 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/36564

#7 Updated by Ronny Vorpahl over 4 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#8 Updated by Gerrit Code Review over 4 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/36578

#9 Updated by Ronny Vorpahl over 4 years ago

  • Status changed from Under Review to Resolved

#10 Updated by Anja Leichsenring over 3 years ago

  • Sprint Focus deleted (On Location Sprint)

#11 Updated by Riccardo De Contardi almost 2 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF