Project

General

Profile

Actions

Bug #64710

closed

sysext\form\Tests\Unit\Filter\StripNewLinesFilterTest fails on Windows

Added by Stephan Großberndt almost 10 years ago. Updated about 7 years ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
Tests
Target version:
Start date:
2015-02-01
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
7
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

There were 2 failures:

1) TYPO3\CMS\Form\Tests\Unit\Filter\StripNewLinesFilterTest::filterForStringWithNewlineReturnsStringWithoutNewline with
data set "some^Mtext" ('some\ntext', 'some text')
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-some text
+some  text

D:\typo3\master\typo3\sysext\form\Tests\Unit\Filter\StripNewLinesFilterTest.php:55
D:\typo3\master\Packages\Libraries\phpunit\phpunit\phpunit:62

2) TYPO3\CMS\Form\Tests\Unit\Filter\StripNewLinesFilterTest::filterForStringWithNewlineReturnsStringWithoutNewline with
data set "trailing newline^M" ('trailing newline\n', 'trailing newline ')
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-trailing newline
+trailing newline

D:\typo3\master\typo3\sysext\form\Tests\Unit\Filter\StripNewLinesFilterTest.php:55
D:\typo3\master\Packages\Libraries\phpunit\phpunit\phpunit:62
Actions #1

Updated by Ronny Vorpahl almost 10 years ago

  • Assignee set to Ronny Vorpahl
Actions #2

Updated by Nicole Cordes almost 10 years ago

  • Assignee changed from Ronny Vorpahl to Nicole Cordes
Actions #3

Updated by Nicole Cordes almost 10 years ago

  • Status changed from New to Accepted
  • Assignee changed from Nicole Cordes to Ronny Vorpahl
Actions #4

Updated by Gerrit Code Review almost 10 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/36564

Actions #5

Updated by Ronny Vorpahl almost 10 years ago

The unit tests failed cause you checked out your sources using Windows line break style. This is configurable in the global Git settings.
Use the command "git config --global core.autocrlf input" to change this behavior.

Actions #6

Updated by Gerrit Code Review almost 10 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/36564

Actions #7

Updated by Ronny Vorpahl almost 10 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #8

Updated by Gerrit Code Review almost 10 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/36578

Actions #9

Updated by Ronny Vorpahl almost 10 years ago

  • Status changed from Under Review to Resolved
Actions #10

Updated by Anja Leichsenring almost 9 years ago

  • Sprint Focus deleted (On Location Sprint)
Actions #11

Updated by Riccardo De Contardi about 7 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF