Bug #64710
closed
sysext\form\Tests\Unit\Filter\StripNewLinesFilterTest fails on Windows
100%
Description
There were 2 failures:
1) TYPO3\CMS\Form\Tests\Unit\Filter\StripNewLinesFilterTest::filterForStringWithNewlineReturnsStringWithoutNewline with
data set "some^Mtext" ('some\ntext', 'some text')
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-some text
+some text
D:\typo3\master\typo3\sysext\form\Tests\Unit\Filter\StripNewLinesFilterTest.php:55
D:\typo3\master\Packages\Libraries\phpunit\phpunit\phpunit:62
2) TYPO3\CMS\Form\Tests\Unit\Filter\StripNewLinesFilterTest::filterForStringWithNewlineReturnsStringWithoutNewline with
data set "trailing newline^M" ('trailing newline\n', 'trailing newline ')
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-trailing newline
+trailing newline
D:\typo3\master\typo3\sysext\form\Tests\Unit\Filter\StripNewLinesFilterTest.php:55
D:\typo3\master\Packages\Libraries\phpunit\phpunit\phpunit:62
Updated by Nicole Cordes about 9 years ago
- Assignee changed from Ronny Vorpahl to Nicole Cordes
Updated by Nicole Cordes about 9 years ago
- Status changed from New to Accepted
- Assignee changed from Nicole Cordes to Ronny Vorpahl
Updated by Gerrit Code Review about 9 years ago
- Status changed from Accepted to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/36564
Updated by Ronny Vorpahl about 9 years ago
The unit tests failed cause you checked out your sources using Windows line break style. This is configurable in the global Git settings.
Use the command "git config --global core.autocrlf input" to change this behavior.
Updated by Gerrit Code Review about 9 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/36564
Updated by Ronny Vorpahl about 9 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset db8c98c6d2b0c94340f7aee629b5bad1af42cc2b.
Updated by Gerrit Code Review about 9 years ago
- Status changed from Resolved to Under Review
Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/36578
Updated by Ronny Vorpahl about 9 years ago
- Status changed from Under Review to Resolved
Applied in changeset b023f6e91b5b9c8006f27fd3837b79a2c10b49dd.
Updated by Anja Leichsenring over 8 years ago
- Sprint Focus deleted (
On Location Sprint)
Updated by Riccardo De Contardi over 6 years ago
- Status changed from Resolved to Closed